Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greek locale species the credit card at the wrong location #376

Closed
ST-DDT opened this issue Jan 30, 2022 · 6 comments · Fixed by #484
Closed

Greek locale species the credit card at the wrong location #376

ST-DDT opened this issue Jan 30, 2022 · 6 comments · Fixed by #484
Assignees
@ST-DDT
Labels
c: bug Something isn't working
Milestone
v6.0 - Ensure Pro...

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Jan 30, 2022 •
edited
Loading

Describe the bug

The credit cards should be located here:

src/locales/el/finance/credit_card/

but are located here:

src/locales/el/credit_card/

(This was not caused by us/our refactoring: https://github.com/faker-js/faker/blob/6.0.0-alpha.0/lib/locales/el/index.js#L6)

Reproduction

Try to use the greek ( el) credit card definitions using the default methods.

Additional Info

Discovered in #363

Do not fix before #363 is merged.
@ST-DDT ST-DDT added the c: bug Something isn't working label Jan 30, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 30, 2022

Milestone v6.0 or v6.1 ?

@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Jan 30, 2022
@Shinigami92
Copy link
Member

Milestone v6.0 or v6.1 ?

If it was cause by us, then maybe v6.0, if it introduce runtime-changes between v5.5.3 and v6.0, then v6.1

@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 30, 2022

This was not caused by us. It does introduce runtime change, by providing other credit card information.

@Shinigami92
Copy link
Member

This was not caused by us. It does introduce runtime change, by providing other credit card information.

Okay, IMO this is fine, I think it like we also added some locales because they weren't imported.

@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 30, 2022

Do not fix before #363 is merged.

@ejcheng ejcheng added the s: on hold Blocked by something or frozen to avoid conflicts label Jan 30, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 3, 2022

Do not fix before #398 is merged.

@ST-DDT ST-DDT self-assigned this Feb 13, 2022
@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Feb 13, 2022
@ST-DDT ST-DDT mentioned this issue Feb 13, 2022
Merged
Repository owner moved this from Todo to Done in Faker Roadmap Feb 15, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: bug Something isn't working
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging a pull request may close this issue.

fix: move el credit card information to the expected location faker-js/faker
3 participants
@ST-DDT @Shinigami92 @ejcheng