Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datatype.bigint takes value and gives it just back #348

Closed
Shinigami92 opened this issue Jan 29, 2022 · 0 comments · Fixed by #791
Closed

datatype.bigint takes value and gives it just back #348

Shinigami92 opened this issue Jan 29, 2022 · 0 comments · Fixed by #791
Assignees
@Shinigami92
Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v7 - Current Major

Comments

@Shinigami92
Copy link
Member

Clear and concise description of the problem

When using faker.datatype.bigint(42) it will just give back 42n
This is not useful and not randomized

Suggested solution

We should change the behavior to something useful or just remove the argument

Alternative

No response

Additional context

No response
@Shinigami92 Shinigami92 added the s: pending triage Pending Triage label Jan 29, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Jan 29, 2022
@Shinigami92 Shinigami92 mentioned this issue Jan 29, 2022
Merged
@ejcheng ejcheng added c: bug Something isn't working and removed s: pending triage Pending Triage labels Feb 2, 2022
@ejcheng ejcheng moved this to Todo in Faker Roadmap Feb 12, 2022
@Shinigami92 Shinigami92 self-assigned this Apr 6, 2022
@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap Apr 6, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 6, 2022
@Shinigami92 Shinigami92 linked a pull request Apr 6, 2022 that will close this issue
feat: reimplement datatype.bigInt #791
Merged
Repository owner moved this from In Progress to Done in Faker Roadmap May 23, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v7 - Current Major
Development

Successfully merging a pull request may close this issue.

feat: reimplement datatype.bigInt faker-js/faker
2 participants
@Shinigami92 @ejcheng