From 9d6eec57737ceb82ddd6b94cb5214d28d461c557 Mon Sep 17 00:00:00 2001 From: Shinigami92 Date: Fri, 8 Apr 2022 12:26:27 +0200 Subject: [PATCH] feat: use random.numeric Co-authored-by: ST-DDT --- src/datatype.ts | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/datatype.ts b/src/datatype.ts index 662b725db16..4955e9a8582 100644 --- a/src/datatype.ts +++ b/src/datatype.ts @@ -324,19 +324,15 @@ export class Datatype { throw new FakerError(`Max ${max} should be larger then min ${min}.`); } - // TODO @Shinigami92 2022-04-07: Use faker.random.numeric() from https://github.com/faker-js/faker/pull/797 - const generateRandomBigInt = (length: number) => - BigInt( - Array.from( - { length }, - () => '0123456789'.split('')[this.number({ min: 0, max: 9 })] - ).join('') - ); - const delta = max - min; const offset = - generateRandomBigInt(delta.toString(10).length) % (delta + BigInt(1)); + BigInt( + this.faker.random.numeric(delta.toString(10).length, { + allowLeadingZeros: true, + }) + ) % + (delta + BigInt(1)); return min + offset; }