AsyncFailsafe#future(...) should completeExceptionally(...) not raise

[brianm]

If the circuit is open, I expect the CompletableFuture returned by AsyncFailsafe#future(...) to be already completed with the circuit open, rather than have the future method raise an exception.

A common case of CF oriented APIs is combing them for fan-out type behavior, particularly in the case where they are being used with a circuit breaker. In that case, the failure handling is usually baked into the CF graph, NOT in the construction of the CF graph.

[jhalterman]

Hi Brian,

You are right - the current behavior is to immediately throw CircuitBreakerOpenException on any type of execution attempt, sync or async, if the configured breaker is open. Your point about this messing with the ability to chain CompletableFutures is valid though.

Just to make sure I understand your scenario and have it covered, do you mind sharing an example/test case?

[jhalterman]

@brianm Let me know if this change does or doesn't address your issue. See this test in particular.

[jhalterman]

This has been released in 1.0.4.

[brianm]

Fabulous, thank you!