Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nucleotide-count: replace AssertJ with JUnit assertions #200

Closed
jtigger opened this issue Nov 29, 2016 · 0 comments
Closed

nucleotide-count: replace AssertJ with JUnit assertions #200

jtigger opened this issue Nov 29, 2016 · 0 comments
Labels
code good first issue Good for newcomers

Comments

@jtigger
Copy link
Contributor

jtigger commented Nov 29, 2016

nucleotide-count is using AssertJ. While many agree that the fluent interface is a bit more readable, the JUnit + included Hamcrest matchers are sufficient to write tests that give good signal. Better to minimize the surface area a practitioner must learn.

Per exercism/exercism#3113, we're actively scrubbing uses of 3rd party libraries that are not technically necessary.

Remove AssertJ from this exercise and replace the assertions with that provided by JUnit and Hamcrest.

Hint: This may require including more Hamcrest libraries than what comes with JUnit.
@jtigger jtigger added code good first issue Good for newcomers labels Nov 29, 2016
FridaTveit added a commit to FridaTveit/java that referenced this issue Dec 18, 2016
@FridaTveit
Issue exercism#200: Replaced assertj assertions in nucleotide-count t…
fb48b95 
…ests with junit and assertj assertions. Removed assertj from nucleotide-count gradle build file. Added extra hamcrest library to nucleotide-count gradle build file to be able to use hasEntry for maps.
@FridaTveit FridaTveit mentioned this issue Dec 18, 2016
Merged
@jtigger jtigger closed this as completed Dec 19, 2016
jtigger added a commit that referenced this issue Dec 19, 2016
@jtigger
Merge pull request #217 from FridaTveit/NucleotideCountReplaceAssertj…
3823a1e 
…WithJunit

Issue #200: Replaced assertj assertions in nucleotide-count tests wit…

(fixes #200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtigger