Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linked-list: replace AssertJ with JUnit assertions #196

Closed
jtigger opened this issue Nov 29, 2016 · 0 comments
Closed

linked-list: replace AssertJ with JUnit assertions #196

jtigger opened this issue Nov 29, 2016 · 0 comments
Labels
code good first issue Good for newcomers

Comments

@jtigger
Copy link
Contributor

jtigger commented Nov 29, 2016

linked-list is using AssertJ. While many agree that the fluent interface is a bit more readable, the JUnit + included Hamcrest matchers are sufficient to write tests that give good signal. Better to minimize the surface area a practitioner must learn.

Per exercism/exercism#3113, we're actively scrubbing uses of 3rd party libraries that are not technically necessary.

Remove AssertJ from this exercise and replace the assertions with that provided by JUnit and Hamcrest.

@jtigger jtigger added code good first issue Good for newcomers labels Nov 29, 2016
FridaTveit added a commit to FridaTveit/java that referenced this issue Dec 16, 2016
…st assertions in linked-list. Removed assertj from linked-list gradle build file.
matthewmorgan pushed a commit that referenced this issue Dec 17, 2016
…tions in linked-list. Removed assertj from linked-list gradle build file. (#212)
@jtigger jtigger closed this as completed Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant