Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse_L3_packet: jerk1 used instead of jerk2 in L3 command validation #236

Open
osresearch opened this issue Nov 25, 2024 · 1 comment
Open

parse_L3_packet: jerk1 used instead of jerk2 in L3 command validation #236

osresearch opened this issue Nov 25, 2024 · 1 comment

Comments

@osresearch
Copy link

EggBot/EBB_firmware/app.X/source/ebb.c

Line 2071 in c1afd8a

((gRate2 == 0) && (gAccel2 == 0) && (gJerk1 == 0))

Cut-n-paste error? This incorrectly rejects commands that only move axis 2 from a stand-still (zero initial gRate2 and gAccel2 but with non-zero gJerk2)
@oskay
Copy link
Contributor

oskay commented Nov 25, 2024

Yes, I think so.

osresearch added a commit to osresearch/EggBot that referenced this issue Nov 25, 2024
@osresearch
L3 fixes
bac9e9b 
This patch fixes evil-mad#235 and evil-mad#236 to correctly validate L3 commands
with non-zero jerk2 and also flips the gJerk1 and gJerk2 globals
if the sign on gSteps1 or gSteps2 is negative in legacy mode.
osresearch added a commit to osresearch/EggBot that referenced this issue Nov 25, 2024
@osresearch
L3 fixes
31b2421 
This patch fixes evil-mad#235 and evil-mad#236 to correctly validate L3 commands
with non-zero jerk2 and also flips the gJerk1 and gJerk2 globals
if the sign on gSteps1 or gSteps2 is negative in legacy mode.
@osresearch osresearch mentioned this issue Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oskay @osresearch