Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match retry policy with go etcd client #1393

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

lavacat
Copy link

@lavacat lavacat commented Aug 8, 2024

No description provided.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lavacat
Once this PR has been reviewed and has the lgtm label, please assign fanminshi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lburgazzoli
Copy link
Collaborator

@lavacat thx for the PR, as you have noticed, I do have a very limited amount of time to dedicate to the project, so this PR is much appreciated

@jcferretti
Copy link
Contributor

jcferretti commented Feb 18, 2025

I just found this PR after #1445 had already been merged.

It would have helped if this PR had any linking information to the jepsen report and its dicussion in etcd github issues (that I assumed motivated it); as it was created, there was no context or motivation mentioned. The description in this PR is totally empty, and there is no associated etcd or jetcd issue.

As I mentioned in the discussion thread in etcd-io/etcd#18424 (comment), I don't believe the conditions

return desc.equals("there is no address available") || desc.equals("there is no connection available");

can happen (I don't think the expression in that return can be true), since I do not think UNAVAILABLE is being generated client side here, but actually being sent by the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants