Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect tail from sqlite3_prepare_v2 #274

Closed
ericsink opened this issue Jun 24, 2019 · 2 comments
Closed

Incorrect tail from sqlite3_prepare_v2 #274

ericsink opened this issue Jun 24, 2019 · 2 comments

Comments

@ericsink
Copy link
Owner

The string overload of sqlite2_prepare_v2 sets tail to "\0" instead of "".

@bricelam
@ericsink
Copy link
Owner Author

See dotnet/efcore#16189

ericsink added a commit that referenced this issue Jun 24, 2019
@ericsink
failing test case for #274
741da6b
ericsink added a commit that referenced this issue Jun 24, 2019
@ericsink
fix for #274 -- the tail span coming back from sqlite3_prepare_v2/v3 …
0a773d9 
…has a zero terminator because it is just a slice of the span which was passed down, and it had one.
@ericsink
Copy link
Owner Author

Interesting that this bug was directly related to the issues discussed in #273

@ericsink ericsink mentioned this issue Jun 25, 2019
Merged
@ericsink ericsink closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericsink