SPARQLResultsTSVWriter writes naked/unquoted xsd:strings

[jimsmart]

Current Behavior

Literals of type xsd:string often get written out in SPARQL TSV results without quotes.

This is because of this section of code:

rdf4j/core/queryresultio/text/src/main/java/org/eclipse/rdf4j/query/resultio/text/tsv/SPARQLResultsTSVWriter.java

Line 204 in cd6509b

} else if (!label.isEmpty() && encoded.equals(label) && label.charAt(0) != '<' && label.charAt(0) != '_'

Expected Behavior

The spec for SPARQL Results TSV says:

4.2 Serializing RDF Terms

The SPARQL Results TSV Results Format serializes RDF terms in the results table by using the syntax that SPARQL [SPARQL11-QUERY] and Turtle [TURTLE] use.

IRIs enclosed in <...>, literals are enclosed with double quotes "..." or single quotes ' ...' with optional @lang or ^^ for datatype. The quotes around the lexical form is required.

So, according to this last sentence — plus the reference to Turtle just previous — in TSV SPARQL results, one would expect all xsd:string literals to be quoted, in all circumstances — and not just when they don't pass the conditions in line 204

Steps To Reproduce

From the workbench, execute a SPARQL insert like this:

INSERT DATA
{
  GRAPH <http://example/g> {
  <http://example/s1> <http://example/p1> "o3" .
  }
}

Then execute a query like this:

select ?o { ?s ?p ?o }

Then download the results as SPARQL/TSV, and view in a text editor, to see:

?o
o3

...the o3 there should be "o3".

Version

5.1.0

Are you interested in contributing a solution yourself?

None

Anything else?

No response

[hmottestad]

Can you test out #5262 to see if it fixes your issue?

[jimsmart]

Thanks for your work on this.

Is there a downloadable binary I can test, please?

I'm running the SPARQL server, from the downloadable binary distribution — I'm not running it from source, and I don't have any kind of Java build process setup on my system, sorry!

[hmottestad]

I can try to create one for you. Is it the big jar file or is it the war file?

[jimsmart]

I use both rdf4j-server.war and rdf4j-workbench.war in my webapps folder.

I would imagine that I only need an updated copy of that first one though, the server itself.