-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the CMake interface #2618
Comments
Paging our CMake expert @dnakamura for this one. Are you able to help answer the above question? |
Strictly speaking you don't actually need to use those functions, but they do make life much easier. If I'm being honest I didnt write those functions and only have a sorta vauge understanding of how they work. Ideally I would like to see them repackaged as interface libraries that you can just link against, and have cmake do all the heavy lifting. As I understand it the functions do a couple things:
|
You can read all about the "why" portion of the answer in great detail here: At a 10k foot level we try to save compile time by avoiding virtual inheritance in the JIT. There will also be a discussion on this and a new proposal in the next OMR Architecture Meeting (#2571). If you're interested in the area you can try to attend or view a recording of the discussion. |
It seems to me that the build requires that front-end projects make use of certain CMake functions defined in OmrCompilerSupport.cmake.
For instance - create_omr_compiler_library() - creates the library / but also includes all the Compiler sources. It also appears to ensure that the projects include path is prioritized over the Compiler ones.
Client front-end projects must use these functions I believe?
The text was updated successfully, but these errors were encountered: