Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace startup fails if I add the merge-contribution attribute #22231

Closed
l0rd opened this issue May 23, 2023 · 2 comments
Closed

Workspace startup fails if I add the merge-contribution attribute #22231

l0rd opened this issue May 23, 2023 · 2 comments
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented May 23, 2023 •
edited
Loading

Describe the bug

image

Che version

7.67@latest

Steps to reproduce

Start a workspace on dogfooding instance from https://github.com/l0rd/wildfly-devfile-examples/tree/contribution-bug

Expected behavior

The attribute controller.devfile.io/merge-contribution: true should allow to specify the container where VS Code should be mounted.

I suspect that the devworkspace-generator always add the attribute in the generated DevWorkspace but it should not (c.f. this issue)
@l0rd l0rd added kind/bug Outline of a bug - must adhere to the bug report template. area/dashboard severity/P1 Has a major impact to usage or development of the system. labels May 23, 2023
@amisevsk
Copy link
Contributor

amisevsk commented May 23, 2023 •
edited
Loading

Related: #22155, especially #22155 (comment)

@l0rd
Copy link
Contributor Author

l0rd commented May 23, 2023

Thanks @amisevsk I am closing this issue as duplicated then.

@l0rd l0rd closed this as completed May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@l0rd @amisevsk