Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CORSAdaptor #570

Closed
samutamm opened this issue Apr 2, 2022 · 2 comments
Closed

Simplify CORSAdaptor #570

samutamm opened this issue Apr 2, 2022 · 2 comments

Comments

@samutamm
Copy link
Contributor

samutamm commented Apr 2, 2022

Is your feature request related to a problem? Please describe.
#498 enabled both CORS pre-flight and CORS requests for CORSAdaptor while originally only CORS pre-flight requests were possible. In many cases both CORS pre-flight and CORS requests are necessary and should be enabled by default.

Describe the solution you'd like
Either

  • change default value of supportCORSRequest to true
  • remove supportCORSRequest and support both CORS pre-flight and CORS requests by default.

Describe alternatives you've considered

Additional context


Thanks for contributing 🎉!

@jxd134
Copy link
Contributor

jxd134 commented May 16, 2022

I support the second measure.
Users reduce the cost of learning about cross-domain settings.

@localvar
Copy link
Collaborator

close as #839 resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants