Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line runner appears to pass if exception occurs in CosmosDbConfiguredConditionAttribute #19064

Closed
ajcvickers opened this issue Nov 25, 2019 · 5 comments
Closed

Command line runner appears to pass if exception occurs in CosmosDbConfiguredConditionAttribute #19064

ajcvickers opened this issue Nov 25, 2019 · 5 comments
Labels
area-test closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-bug

Comments

@ajcvickers
Copy link
Contributor

Output from case discussed here where no Cosmos tests are actually running:

C:\aspnet\EntityFrameworkCore>test
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\dotnet-ef.Tests\Debug\netcoreapp5.0\dotnet-ef.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\ef.Tests\Debug\netcoreapp5.0\ef.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.InMemory.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.InMemory.FunctionalTests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Proxies.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Proxies.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.CrossStore.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.CrossStore.FunctionalTests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Design.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Design.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Relational.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Relational.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Sqlite.FunctionalTests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Sqlite.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.SqlServer.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.SqlServer.FunctionalTests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\dotnet-ef.Tests\Debug\netcoreapp5.0\dotnet-ef.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\ef.Tests\Debug\netcoreapp5.0\ef.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Cosmos.FunctionalTests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.InMemory.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Cosmos.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Sqlite.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Proxies.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Proxies.Tests.dll [netcoreapp5.0|x64]
  Running tests: C:\aspnet\EntityFrameworkCore\artifacts\bin\Microsoft.Data.Sqlite.Tests\Debug\netcoreapp5.0\Microsoft.Data.Sqlite.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Relational.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Relational.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Cosmos.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\Microsoft.Data.Sqlite.Tests\Debug\netcoreapp5.0\Microsoft.Data.Sqlite.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Cosmos.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Cosmos.FunctionalTests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.CrossStore.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.CrossStore.FunctionalTests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Design.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Design.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.SqlServer.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Tests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Tests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.Sqlite.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.Sqlite.FunctionalTests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.SqlServer.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.SqlServer.FunctionalTests.dll [netcoreapp5.0|x64]
  Tests succeeded: C:\aspnet\EntityFrameworkCore\artifacts\bin\EFCore.InMemory.FunctionalTests\Debug\netcoreapp5.0\Microsoft.EntityFrameworkCore.InMemory.FunctionalTests.dll [netcoreapp5.0|x64]

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:02:53.56
@ajcvickers ajcvickers mentioned this issue Nov 25, 2019
Merged
@AndriySvyryd
Copy link
Member

It fails correctly on non-Windows systems

@ajcvickers
Copy link
Contributor Author

@dougbu @wtgodbe It looks like the return value is not being checked here, and hence the build assumes the tests passed when actually no tests were even run. What is the appropriate place to follow up on this? Is it specific to EF, something general in ASP.NET, or something for Arcade?

@wtgodbe
Copy link
Member

wtgodbe commented Dec 2, 2019

Hmm, I'm not sure where the command line runner lives. Maybe @ericstj or @riarenas would know?

@dougbu
Copy link
Member

dougbu commented Dec 2, 2019

What tool are we talking about @ajcvickers ❔

@ajcvickers
Copy link
Contributor Author

@dougbu Either the test runner itself, or the way it is used by the build scripts.

@ajcvickers ajcvickers self-assigned this Dec 6, 2019
@ajcvickers ajcvickers added this to the 5.0.0 milestone Dec 6, 2019
@ajcvickers ajcvickers removed this from the 5.0.0 milestone Mar 12, 2020
@ajcvickers ajcvickers added closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. and removed needs-design propose-close labels Mar 12, 2020
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajcvickers @dougbu @AndriySvyryd @wtgodbe