Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Improve result verification in null semantics #18849

Closed
smitpatel opened this issue Nov 11, 2019 · 0 comments
Closed

Test: Improve result verification in null semantics #18849

smitpatel opened this issue Nov 11, 2019 · 0 comments
Assignees
@maumar
Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
5.0.0

Comments

@smitpatel
Copy link
Contributor

  • Use AssertQuery for sync/async both.
  • Deep verification of results.

Or #18803 (comment) :trollface:
@ajcvickers ajcvickers added this to the 5.0.0 milestone Nov 15, 2019
maumar added a commit that referenced this issue Jan 3, 2020
@maumar
Fix to #18849 - Test: Improve result verification in null semantics
940ec1a 
Tests now run sync and async. We also perform result verification.
@maumar maumar mentioned this issue Jan 3, 2020
Closed
maumar added a commit that referenced this issue Jan 3, 2020
@maumar
Fix to #18849 - Test: Improve result verification in null semantics
e7febd0 
Tests now run sync and async. We also perform result verification.

Resolves #18849
@maumar maumar self-assigned this Jan 8, 2020
@maumar maumar closed this as completed in af81c0c Jan 8, 2020
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 8, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @smitpatel @maumar