Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review API consistency tests #18545

Closed
bricelam opened this issue Oct 23, 2019 · 1 comment
Closed

Review API consistency tests #18545

bricelam opened this issue Oct 23, 2019 · 1 comment
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@bricelam
Copy link
Contributor

It looks like they missed flagging a non-virtual property (Sql) on SqlFragmentExpression when it had an internal constructor. We investigate why to see if other similar issues are going unreported.
@ajcvickers ajcvickers added this to the Backlog milestone Oct 25, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Nov 20, 2019
@ajcvickers ajcvickers self-assigned this Mar 11, 2020
@ajcvickers
Copy link
Contributor

Fixed by #19081

@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 11, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@bricelam bricelam removed their assignment Jul 26, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@bricelam @ajcvickers