Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portal.main failure with 0.5.0 and babashka 0.2.0 #14

Closed
cldwalker opened this issue Sep 16, 2020 · 2 comments
Closed

portal.main failure with 0.5.0 and babashka 0.2.0 #14

cldwalker opened this issue Sep 16, 2020 · 2 comments

Comments

@cldwalker
Copy link

Hi. Thanks for this awesome tool. When I tried this with the latest portal and babashka, I get the following failure:

$ cat deps.edn | bb -cp `clj -Spath -Sdeps '{:deps {djblue/portal {:mvn/version "RELEASE"}}}'` -m portal.main edn
----- Error --------------------------------------------------------------------
Type:     java.lang.NullPointerException
Location: portal/http_socket_server.clj:81:21

----- Context ------------------------------------------------------------------
77:                             (try (.accept server-socket)
78:                                  (catch Exception _e))]
79:                    (start-worker-thread client-socket handler))))}))
80:
81: (defn wait [server] @(:future server))
                        ^---
82:
83: (defn stop [server]
84:   (.close ^ServerSocket (:server-socket server)))

----- Locals -------------------------------------------------------------------
server: nil

----- Stack trace --------------------------------------------------------------
clojure.core/deref             - <built-in>
portal.http-socket-server/wait - portal/http_socket_server.clj:81:21
portal.http-socket-server/wait - portal/http_socket_server.clj:81:1
portal.main                    - portal/main.clj:71:5
clojure.core/apply             - <built-in>
user                           - <expr>:1:36

I didn't know if this failure was known. Is this related to babashka/sci#401?

@djblue
Copy link
Owner

djblue commented Sep 16, 2020

Hi @cldwalker, I'm glad you like portal and thanks for the report! I did accidentally break portal.main but just released 0.5.1 so it should be fixed.

@cldwalker
Copy link
Author

Confirmed the latest works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants