Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cuts more accessible #387

Closed
3y3 opened this issue Mar 6, 2024 · 3 comments
Closed

Make cuts more accessible #387

3y3 opened this issue Mar 6, 2024 · 3 comments
Labels
a11y help wanted Extra attention is needed

Comments

@3y3
Copy link
Member

3y3 commented Mar 6, 2024

Cuts final html doesn't have role and state

Looks like we need expanded state and some relevant role.
@3y3 3y3 added a11y help wanted Extra attention is needed labels Mar 6, 2024
@martyanovandrey
Copy link
Contributor

martyanovandrey commented Apr 24, 2024 •
edited
Loading

  • Cut also can use <details> tag, need to investigate it.
  • Сurrent implementation cannot be used from the keyboard. See also about tabindex

@martyanovandrey
Copy link
Contributor

Proposal:
#405 (comment)

Changes needed here:
https://github.com/diplodoc-platform/transform/blob/master/src/transform/plugins/cut.ts
and probably here:
https://github.com/diplodoc-platform/transform/blob/master/src/js/cut.ts

@martyanovandrey
Copy link
Contributor

done
#476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y help wanted Extra attention is needed
Projects
A11y improvement
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@3y3 @martyanovandrey