From 082c7c1fcfdc0a87b990655982e14957666c83c4 Mon Sep 17 00:00:00 2001 From: Edmund Craske Date: Tue, 22 Mar 2016 13:19:24 +0000 Subject: [PATCH] Fail if failover set when set_identifier unset Added as per https://github.com/hashicorp/terraform/pull/5777#issuecomment-199802514 --- builtin/providers/aws/resource_aws_route53_record.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/builtin/providers/aws/resource_aws_route53_record.go b/builtin/providers/aws/resource_aws_route53_record.go index 6a3b3733dadb..ee33842584d8 100644 --- a/builtin/providers/aws/resource_aws_route53_record.go +++ b/builtin/providers/aws/resource_aws_route53_record.go @@ -455,6 +455,9 @@ func resourceAwsRoute53RecordBuildSet(d *schema.ResourceData, zoneName string) ( } if v, ok := d.GetOk("failover"); ok { + if _, ok := d.GetOk("set_identifier"); !ok { + return nil, fmt.Errorf(`provider.aws: aws_route53_record: %s: "set_identifier": required field is not set when "failover" is set`, d.Get("name").(string)) + } rec.Failover = aws.String(v.(string)) }