Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning before deleting browser progress #355

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add warning before deleting browser progress #355

wants to merge 3 commits into from

Conversation

vbakke
Copy link
Collaborator

@vbakke vbakke commented Jan 19, 2025

Fixes #334, by warning the user before any localStorage is deleted

@vbakke
Copy link
Collaborator Author

vbakke commented Jan 19, 2025 •
edited
Loading

@0x41head or @PAVAN507-STAR, could you please explain to me what I have done wrong her? I'm not familiar with Angular, and its test setup.

@PAVAN507-STAR
Copy link

@0x41head or @PAVAN507-STAR, could you please explain to me what I have done wrong her? I'm not familiar with Angular, and its test setup.

I'm guessing it has something to do with the other pr opened by bot which states the codebase's angular needs to be updated from 13=> 19 or so.I think your pr is related to it once confirm it with other maintainers.

@vbakke
Copy link
Collaborator Author

vbakke commented Jan 27, 2025

@0x41head or @wurstbrot: Any hints on what I have to do to make the unit test work as expected?

@0x41head
Copy link
Collaborator

The Github Action logs seems to indicate its the new test that you have created with the modal-message component that are causing issues. Try to see if you can fix that.

@wurstbrot wurstbrot mentioned this pull request Jan 29, 2025
Merged
@vbakke
Copy link
Collaborator Author

vbakke commented Feb 2, 2025

I managed to get the unit tests to pass, @0x41head. Would you mind doing a review, please?

0x41head
0x41head approved these changes Feb 8, 2025
View reviewed changes
Copy link
Collaborator

@0x41head 0x41head left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x41head 0x41head 0x41head approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All data gone, without a warning
3 participants
@vbakke @PAVAN507-STAR @0x41head