Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with WHATWG at URL and URLSearchParams #1551

Closed
watilde opened this issue Jan 19, 2019 · 3 comments
Closed

Compatibility with WHATWG at URL and URLSearchParams #1551

watilde opened this issue Jan 19, 2019 · 3 comments

Comments

@watilde
Copy link
Contributor

watilde commented Jan 19, 2019

Hello 👋

As I mentioned at #1549, we need to add more things to have compatibility with URL specification in WHATWG and make sure if it's correct by running all WPT tests.

I'm wondering if it's ok to just use jsdom/whatwg-url instead of having full implementation and running all tests in WPT.

@kitsonk
Copy link
Contributor

kitsonk commented Jan 20, 2019

As mentioned in the original PR for URL it wasn't intended to follow the spec exactly: #1359 . The jsdom/whatwg-url has a lot of logic, following the specification exactly, that really is a bit overkill. My opinion is we should just fix issues when we find them.

@watilde
Copy link
Contributor Author

watilde commented Jan 21, 2019

I'm not quite sure which part can be exactly overkilled in WHATWG URL yet, but I'm sure they really cover almost all edge cases. For me, one more big plus here is that we can update the spec itself if there is any useless process which also updates whatwg-url :)

For this part,

we should just fix issues when we find them.

One of the effecient ways to find them is running WPT tests and I could find a lot already. That was the original reason why I started writing a patch.

@piscisaureus
Copy link
Member

Fixed in #853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants