-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmet peer dependencies #1678
Comments
Why these |
For Netlify CMS plugins, they are listed as peer dependencies because they have to be used with the CMS -- which has them in |
Same issue, though slightly different version numbers.
Applicable Versions: Netlify CMS version: 2.0.11 |
Just FYI -- this is something we want to fix if possible, but it isn't actually causing any problems, so it may take a while as we work on other priorities. |
I disagree that it isn't actually causing any problems. These messages adds 140+ lines to the Netlify deploy log file which does make it more difficult to debug. Not a serious problem, but still... |
This is a small symptom of the issue that #1858 is meant to solve. We're almost there. |
It was superseded by a bunch of issues and PR's by the illustrious @talves. But the effort didn't address the logs. The peer deps thing is a challenge, bit of a semver nightmare, really. I often think about moving to fixed versioning for bigger reasons than what this issue is about, but it would likely address this as well. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@verythorough I'm not thrilled to see a noise bot on the Netlify tracker .. these bots that purport to clean things up usually just make extra work. In this case, the issue documented is as relevant as ever. Either that, or it has indeed been fixed. In either case , Triaging old issues is a virtuous chore, but it has to be done with understanding, and it should not generate noise in the tracker --- e.g. it could be done using a date filter. ( |
@jean I do like improving communication! I'm tagging @erquhart and @erezrokah to see your comment above, because they're the ones tasked with triaging issues and choosing which bots to add. :) |
Hey @jean you make some very strong points and the I also disabled the stale bot for now to give us some more time to go over the issues it marked - we already closed a few state/duplicate ones manually and pinned the relevant ones. While not being the best solution the bot did forced us to go over these issues. Going forward we should triage old issues regularly and using a filter does makes sense. Since we can't fix all issues (even if they are still relevant) we should find a way to keep them around as reference, while still being able to focus on the ones we can fix. |
@erezrokah thanks for your gracious consideration 😸
I think these bots have some positive effects, but the negative effects are too easily missed and cause real damage.
I don't mind many issues as long as I can filter easily. E.g. be strict about issue assignment and subscription, so that you can easily filter to your issues. Be strict about labeling issues as early and automatically as possible. A live issue should have a That's another 2c from me :-p |
Hey, any update on this issue? |
Hello, When I install the last `netlify-cms version, I have a lot of warnings:
Describe the bug
Too much warnigns during install
To Reproduce
yarn add netlify-cms
Expected behavior
No warning during install
Applicable Versions:
The text was updated successfully, but these errors were encountered: