-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-1043] Support google-cloud-bigquery 3.x.x dependency #269
Comments
@whittid4 thanks for opening and we'd welcome a PR for this! I think this is the last time the upper bounds were adjusted (before this adapter was migrated from Based on the discussion there, we'd welcome relaxing the upper bounds further:
So this looks like an upper bound to protect against "unknowns" rather than "knowns". Acceptance criteria:
|
Thanks @dbeatty10, I will have a read through the contributing guide as I have not contributed to this repo before and try and get a PR up |
@whittid4 I would to have a go at this issue. first time contributor. would it be dependency change to allow 3.2.0? can guidance much appreciated |
@dbeatty10 Hi Doug, one of our engineers (eplus-aolalere) submitted a PR for this issue. Would you (or another maintainer on the team) be able to review the PR and see if it can progress? Thank you |
Describe the feature
dbt-bigquery
requires a version ofgoogle-cloud-bigquery
that is less than 3, but I have another dependency that has a minimum requirement of 3.2.0 and causing a conflictDescribe alternatives you've considered
No alternatives considered apart from not upgrading other dependencies that require
google-cloud-bigquery
Who will this benefit?
Anyone using
dbt-bigquery
along with other dependencies that require bigqueryAre you interested in contributing this feature?
I would be happy to contribute to this unless there is a reason why the version has been pinned
The text was updated successfully, but these errors were encountered: