Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1043] Support google-cloud-bigquery 3.x.x dependency #269

Closed
whittid4 opened this issue Aug 16, 2022 · 4 comments · Fixed by #332
Closed

[CT-1043] Support google-cloud-bigquery 3.x.x dependency #269

whittid4 opened this issue Aug 16, 2022 · 4 comments · Fixed by #332
Labels
good_first_issue Good for newcomers type:enhancement New feature or request

Comments

@whittid4
Copy link

Describe the feature

dbt-bigquery requires a version of google-cloud-bigquery that is less than 3, but I have another dependency that has a minimum requirement of 3.2.0 and causing a conflict

dbt-bigquery (>=1.2.0,<2.0.0) requires google-cloud-bigquery (>=1.25.0,<3)

Describe alternatives you've considered

No alternatives considered apart from not upgrading other dependencies that require google-cloud-bigquery

Who will this benefit?

Anyone using dbt-bigquery along with other dependencies that require bigquery

Are you interested in contributing this feature?

I would be happy to contribute to this unless there is a reason why the version has been pinned

@whittid4 whittid4 added type:enhancement New feature or request triage:product labels Aug 16, 2022
@github-actions github-actions bot changed the title Support google-cloud-bigquery 3.x.x dependency [CT-1043] Support google-cloud-bigquery 3.x.x dependency Aug 16, 2022
@dbeatty10 dbeatty10 self-assigned this Aug 17, 2022
@dbeatty10
Copy link
Contributor

@whittid4 thanks for opening and we'd welcome a PR for this!

I think this is the last time the upper bounds were adjusted (before this adapter was migrated from dbt-core into its own dbt-bigquery repo):

Based on the discussion there, we'd welcome relaxing the upper bounds further:

  • I didn't see any known incompatibilities discussed there.
  • The upper bound of <3 for google-cloud-bigquery was merged on 2021-04-02, but google-cloud-bigquery 3.0.0 wasn't released until almost exactly a year later.

So this looks like an upper bound to protect against "unknowns" rather than "knowns".

Acceptance criteria:

  • If all the tests pass after you relax the relevant upper bounds, then we should be clear for takeoff ✈️

@dbeatty10 dbeatty10 added good_first_issue Good for newcomers type:enhancement New feature or request and removed type:enhancement New feature or request triage:product labels Aug 17, 2022
@whittid4
Copy link
Author

Thanks @dbeatty10, I will have a read through the contributing guide as I have not contributed to this repo before and try and get a PR up

@dbeatty10 dbeatty10 removed their assignment Sep 9, 2022
@essp-lbg
Copy link

essp-lbg commented Sep 23, 2022

@whittid4 I would to have a go at this issue. first time contributor. would it be dependency change to allow 3.2.0? can guidance much appreciated

@d-casal
Copy link
Contributor

d-casal commented Oct 3, 2022

@dbeatty10 Hi Doug, one of our engineers (eplus-aolalere) submitted a PR for this issue. Would you (or another maintainer on the team) be able to review the PR and see if it can progress? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good_first_issue Good for newcomers type:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants