Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub partial deadlock with angular-0.13.0 transformer #20312

Closed
DartBot opened this issue Aug 1, 2014 · 4 comments
Closed

Pub partial deadlock with angular-0.13.0 transformer #20312

DartBot opened this issue Aug 1, 2014 · 4 comments
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable

Comments

@DartBot
Copy link

DartBot commented Aug 1, 2014

This issue was originally filed by @taisph


What steps will reproduce the problem?

  1. Create a basic Angular app. You can use https://github.com/taisph/angular.dart-attach-test
  2. Run pub get and pub serve --port 8083.
  3. Run curl http://localhost:8083/main.dart and a proper response is returned.
  4. Make a change in web/main.dart and save.
  5. Run curl http://localhost:8083/main.dart and curl now hangs waiting for a response.

What is the expected output? What do you see instead?
I expected to get a "Build completed successfully" message in the pub serve console and the result returned to curl after the change.

What version of the product are you using?
± pub version
Pub 1.5.3

± pub deps
angular_dart_attach_test 0.0.0
|-- angular 0.13.0
| |-- browser...
| |-- web_components...
| |-- analyzer 0.18.0
| | |-- args...
| | |-- logging...
| | |-- path...
| | '-- typed_mock 0.0.4
| |-- args 0.10.0+2
| | '-- collection...
| |-- barback 0.14.0+3
| | |-- collection...
| | |-- path...
| | |-- source_maps...
| | '-- stack_trace 0.9.3+2
| | '-- path...
| |-- code_transformers 0.1.6
| | |-- analyzer...
| | |-- barback...
| | |-- path...
| | '-- source_maps...
| |-- collection 0.9.4
| |-- di 2.0.1
| | |-- analyzer...
| | |-- barback...
| | |-- code_transformers...
| | '-- path 1.2.2
| |-- html5lib 0.10.0
| | |-- source_maps 0.9.4
| | | |-- path...
| | | '-- source_span 1.0.0
| | | '-- path...
| | '-- utf 0.9.0+1
| |-- intl 0.8.10+4
| | |-- analyzer...
| | |-- path...
| | '-- meta 0.8.8
| |-- perf_api 0.0.8
| '-- route_hierarchical 0.4.21
| |-- browser...
| '-- logging 0.9.2
|-- browser 0.10.0+2
'-- web_components 0.3.5+1

On what operating system?
Ubuntu 14.04 64-bit

Please provide any additional information below.
Issue originally raised in Angular's issue tracker but was closed stating this was a pub bug.

dart-archive/angular.dart#1276

@DartBot
Copy link
Author

DartBot commented Aug 1, 2014

This comment was originally written by @vicb


Note: Step 3-5 are done with pub serve running. If you terminate pub serve after the first request an re-start after right before the second request, there is no more issue.

Seems like the issue is with modifying a served file.

For some reason, it used to work with Angular 0.12 - The issue being reported is triggered on angular 0.13.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Added Area-Pub, Triaged labels.

@nex3
Copy link
Member

nex3 commented Aug 4, 2014

This is almost certainly an issue in Angular and/or code_transformers. I'll explain in more detail on the Angular bug.


Added Invalid label.

@DartBot DartBot added Type-Defect closed-invalid Closed as we don't believe the reported issue is generally actionable labels Aug 4, 2014
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#1077.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable
Projects
None yet
Development

No branches or pull requests

4 participants