From b691fd9a0e25e8a916e5f2e47ac367d8b24f545a Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Thu, 22 May 2014 16:40:14 +0200 Subject: [PATCH] chore(pubspec): bump SDK version (>= 1.4.0) Closes #1009 --- pubspec.lock | 4 ++-- pubspec.yaml | 2 +- test/core/scope_spec.dart | 8 +------- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/pubspec.lock b/pubspec.lock index 8aef64e6f..dc4a9ab74 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -24,7 +24,7 @@ packages: code_transformers: description: code_transformers source: hosted - version: "0.1.3" + version: "0.1.3+1" collection: description: collection source: hosted @@ -36,7 +36,7 @@ packages: guinness: description: guinness source: hosted - version: "0.1.3" + version: "0.1.4" html5lib: description: html5lib source: hosted diff --git a/pubspec.yaml b/pubspec.yaml index 0ec48ae0e..eb984f17f 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -11,7 +11,7 @@ authors: description: Angular for dart. homepage: https://angulardart.org environment: - sdk: '>=1.3.0' + sdk: '>=1.4.0' dependencies: args: '>=0.10.0 < 0.11.0' analyzer: '>=0.13.0 <0.14.0' diff --git a/test/core/scope_spec.dart b/test/core/scope_spec.dart index cb8147daa..704f7b523 100644 --- a/test/core/scope_spec.dart +++ b/test/core/scope_spec.dart @@ -1291,13 +1291,7 @@ void main() { it('should properly watch array of fields 3', (RootScope rootScope, Logger log) { rootScope.context['foo'] = 'abc'; - String expression = 'foo.contains("b")'; - if (identical(1, 1.0)) { // dart2js - // The previous expression does not work in dart2js (http://dartbug.com/18673) - // Use a working one for now. - expression = 'foo.contains("b", 0)'; - } - rootScope.watch(expression, (v, o) => log([v, o])); + rootScope.watch('foo.contains("b")', (v, o) => log([v, o])); expect(log).toEqual([]); rootScope.apply(); expect(log).toEqual([[true, null]]);