Skip to content

read.ctd.sbe() rename arg should accept a character value #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dankelley opened this issue Feb 12, 2025 · 0 comments
Open

read.ctd.sbe() rename arg should accept a character value #2296

dankelley opened this issue Feb 12, 2025 · 0 comments
Assignees

Comments

@dankelley
Copy link
Owner

I want it to be such that a user can do either

A <- read.ctd.sbe(..., rename = FALSE) |> rename("sbe")
B <- read.ctd.sbe(..., rename = "sbe")

to get identical results.

At present, an error is reported if a non-logical value is used for rename, so the change I have in mind will not require users to change their code. It will just be a simpler, one-step, method.

I actually thought we had this ... the reason I want to add it now is that I just wrote code assuming it worked ... that's a good test of things we ought to provide, I reckon.

@dankelley dankelley self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant