Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Reopen in non-private window #10

Open
vendillah opened this issue Nov 19, 2022 · 1 comment
Open

FR: Reopen in non-private window #10

vendillah opened this issue Nov 19, 2022 · 1 comment

Comments

@vendillah
Copy link

Description of the feature request:

Maybe counter intuitive, but the extension could also provide an option to move it back to the non-private window, perhaps by showing a slightly different icon when in a private window and changing its functionality to "open in non-private window" instead of "open in another private window".

This extension does exactly that, but it's not open sourced.

@cpeterso
Copy link
Owner

Thanks for the suggestion! I'll check out that extension.

I didn't realize my extension opens a second private window if the page is already in a private window. I never tested that case! My opinion is that the extension should probably do nothing or open a second tab in the same private window, but I'll leave your suggestion open for other people to comment on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants