Correctly Returning Height in Queries

[alexanderbez]

Summary

Through #4573 we introduced the ability to inject the height in query responses. That is, the height at the time for which the resource was queried at was injected into the response.

Problem Definition

Turns out that the height in the result you receive from ABCIQueryWithOptions is actually the height you specify! In other words, Tendermint does automatically give you this height. Only when you actually provide the height does it return that to you...essentially making #4573 redundant atm (unless you actually specified a height in the query).

Proposal

Since upstream clients and consumers want to the know the height at which a resource was queried at (actually implementing the intended functionality of #4573), we need to automatically and behind the scenes query for the current block height (we already have this logic) and update the CLIContext to include this.

However, this now means one additional internal query per client query. To circumvent this, we can cache the height in the client code somewhere.

/cc @jackzampolin @colin-axner

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned