coralogix
diff --git a/‎ballista/core/Cargo.toml
+1-1 b/‎ballista/core/Cargo.toml
+1-1
diff --git a/‎ballista/core/build.rs
+2-2 b/‎ballista/core/build.rs
+2-2
diff --git a/‎ballista/core/proto/ballista.proto
+1 b/‎ballista/core/proto/ballista.proto
+1
diff --git a/‎ballista/core/src/serde/physical_plan/from_proto.rs
+2 b/‎ballista/core/src/serde/physical_plan/from_proto.rs
+2
diff --git a/‎ballista/core/src/serde/physical_plan/mod.rs
+7-1 b/‎ballista/core/src/serde/physical_plan/mod.rs
+7-1
@@ -55,9 +55,9 @@ datafusion-objectstore-hdfs = { version = "0.1.1", default-features = false, opt
 datafusion-proto = "17.0.0"
 futures = "0.3"
 hashbrown = "0.13"
+itertools = "0.10"
 
 lazy_static = "1.4.0"
-itertools = "0.10"
 libloading = "0.7.3"
 log = "0.4"
 lru = "0.8.1"
 
@@ -26,7 +26,7 @@ fn main() -> Result<(), String> {
     println!("cargo:rerun-if-env-changed=FORCE_REBUILD");
 
     let version = rustc_version::version().unwrap();
-    println!("cargo:rustc-env=RUSTC_VERSION={version}");
+    println!("cargo:rustc-env=RUSTC_VERSION={}", version);
 
     // TODO: undo when resolved: https://github.com/intellij-rust/intellij-rust/issues/9402
     #[cfg(feature = "docsrs")]
@@ -42,7 +42,7 @@ fn main() -> Result<(), String> {
         tonic_build::configure()
             .extern_path(".datafusion", "::datafusion_proto::protobuf")
             .compile(&["proto/ballista.proto"], &["proto"])
-            .map_err(|e| format!("protobuf compilation failed: {e}"))?;
+            .map_err(|e| format!("protobuf compilation failed: {}", e))?;
         let generated_source_path = out.join("ballista.protobuf.rs");
         let code = std::fs::read_to_string(generated_source_path).unwrap();
         let mut file = std::fs::OpenOptions::new()
 
@@ -95,6 +95,7 @@ message AvroScanExecNode {
 enum PartitionMode {
   COLLECT_LEFT = 0;
   PARTITIONED = 1;
+  AUTO = 2;
 }
 
 message HashJoinExecNode {
 
@@ -411,6 +411,8 @@ impl TryInto<FileScanConfig> for &protobuf::FileScanExecConf {
             projection,
             limit: self.limit.as_ref().map(|sl| sl.limit as usize),
             table_partition_cols: vec![],
+            // TODO add ordering info to the ballista proto file
+            output_ordering: None,
         })
     }
 }
@@ -331,6 +331,8 @@ impl AsExecutionPlan for PhysicalPlanNode {
                     physical_window_expr,
                     input,
                     Arc::new((&input_schema).try_into()?),
+                    vec![],
+                    None,
                 )?))
             }
             PhysicalPlanType::Aggregate(hash_agg) => {
@@ -528,6 +530,7 @@ impl AsExecutionPlan for PhysicalPlanNode {
                 let partition_mode = match partition_mode {
                     protobuf::PartitionMode::CollectLeft => PartitionMode::CollectLeft,
                     protobuf::PartitionMode::Partitioned => PartitionMode::Partitioned,
+                    protobuf::PartitionMode::Auto => PartitionMode::Auto,
                 };
                 Ok(Arc::new(HashJoinExec::try_new(
                     left,
@@ -800,7 +803,7 @@ impl AsExecutionPlan for PhysicalPlanNode {
                         input: Some(Box::new(input)),
                         skip: limit.skip() as u32,
                         fetch: match limit.fetch() {
-                            Some(n) => *n as i64,
+                            Some(n) => n as i64,
                             _ => -1, // no limit
                         },
                     },
@@ -875,6 +878,7 @@ impl AsExecutionPlan for PhysicalPlanNode {
             let partition_mode = match exec.partition_mode() {
                 PartitionMode::CollectLeft => protobuf::PartitionMode::CollectLeft,
                 PartitionMode::Partitioned => protobuf::PartitionMode::Partitioned,
+                PartitionMode::Auto => protobuf::PartitionMode::Auto,
             };
 
             Ok(protobuf::PhysicalPlanNode {
@@ -1285,6 +1289,7 @@ fn decode_scan_config(
         projection,
         limit: proto.limit.as_ref().map(|sl| sl.limit as usize),
         table_partition_cols: vec![],
+        output_ordering: None,
     })
 }
 
@@ -1612,6 +1617,7 @@ mod roundtrip_tests {
             projection: None,
             limit: None,
             table_partition_cols: vec![],
+            output_ordering: None,
         };
 
         let predicate = datafusion::prelude::col("col").eq(datafusion::prelude::lit("1"));
Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ message AvroScanExecNode {`
`95`	`95`	`enum PartitionMode {`
`96`	`96`	`COLLECT_LEFT = 0;`
`97`	`97`	`PARTITIONED = 1;`
	`98`	`+ AUTO = 2;`
`98`	`99`	`}`
`99`	`100`
`100`	`101`	`message HashJoinExecNode {`
Original file line number	Diff line number	Diff line change
`@@ -411,6 +411,8 @@ impl TryInto<FileScanConfig> for &protobuf::FileScanExecConf {`
`411`	`411`	`projection,`
`412`	`412`	`limit: self.limit.as_ref().map(\|sl\| sl.limit as usize),`
`413`	`413`	`table_partition_cols: vec![],`
	`414`	`+ // TODO add ordering info to the ballista proto file`
	`415`	`+ output_ordering: None,`
`414`	`416`	`})`
`415`	`417`	`}`
`416`	`418`	`}`