Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Issues #554

Open
zeshanziya opened this issue Jul 16, 2024 · 2 comments
Open

Setup Issues #554

zeshanziya opened this issue Jul 16, 2024 · 2 comments

Comments

@zeshanziya
Copy link
Collaborator

We have identified a few issues when setting up this project on a new machine:

  1. Users get confused about setting the Platform.sh CLI token.
  2. PHP needs to be installed on the local machine because we are using GrumPHP, which runs on pre-commit hooks. If PHP is not installed, users cannot commit changes.
  3. After running ddev pull platform, a few directories (tmp, private, drush) are created and are not excluded from Git, so users may accidentally push these changes.
@hussainweb
Copy link
Member

Thanks, @zeshanziya. I understand that the first two problems are related to documentation. For 3, shall we add those lines to .gitignore? My concern with adding .drush is that we might want to add that ourselves in the future. What do you think?

@zeshanziya
Copy link
Collaborator Author

@hussainweb For point 2, I was thinking if we can change the pre-commit hook and execute the grumphp command using ddev. this way, we can remove the dependency on local php requirement completely. But that again will not work if ddev is not running and user tries to commit.

If we plan to use local php to be installed, then we should mention latest php version to be installed in documentation.

For point 3, I think, we can push all these directories with a .gitignore so these directories are available and ignored as well.

*
!.gitignore

What's your thought?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants