-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Prepare for development #12
Conversation
{:confex, "~> 3.2.3"}, | ||
{:uuid, "~> 1.1"}, | ||
{:jason, "~> 1.4"}, | ||
{:confex, "~> 3.0"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove confex and use System or Application module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that would be a breaking change? confex
is for users to set variables as {:system, "GREMLEX_HOST", "127.0.0.1"}
instead of System.get_env("GREMLEX_HOST", "127.0.0.1")
. The thing is confex
supports also file config, casting to integer
, atom
, etc.
graph: | ||
image: tinkerpop/gremlin-server:3.7 | ||
ports: | ||
- 8182:8182 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 8182:8182 | |
- 8183:8182 |
different internal - external port
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is usually done for reserved/assigned ports. In the case of port 8182 it is not assigned. If it ever conflicts with someone's local setup we can set this as an env var like
ports:
- ${GREMLEX_SERVER_PORT}:8182
and use an .env
file like
GREMLEX_SERVER_PORT=8182
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
.tool-versions
:httpoison
uuid
and vendorEcto.UUID.generate/0
insteadmock
withmox
, or delete if the dependency is not requiredmix_test_watch
ex_doc
stream_data
poison
withjason
gremlex
is already taken. We would have to create a new package, or if we do not plan on publishing it then we will always have to reference viagit
README.md
There is only one caveat/issue.
:socket
library is unmaintained, and it throws type errors. The library could be replaced by https://github.com/elixir-mint/mint_web_socket but it might require some additional refactoring.