From 392db85958451787e41b055b58c78de246429443 Mon Sep 17 00:00:00 2001 From: Mateusz Baginski Date: Thu, 14 Mar 2024 08:05:45 +0100 Subject: [PATCH 1/4] Fix incorrect focus order in pagination --- packages/ckeditor5-ui/src/input/inputbase.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/ckeditor5-ui/src/input/inputbase.ts b/packages/ckeditor5-ui/src/input/inputbase.ts index 82119933637..1a558202854 100644 --- a/packages/ckeditor5-ui/src/input/inputbase.ts +++ b/packages/ckeditor5-ui/src/input/inputbase.ts @@ -46,6 +46,13 @@ export default abstract class InputBase Date: Mon, 18 Mar 2024 14:12:25 +0100 Subject: [PATCH 2/4] Fix incorrect merge --- packages/ckeditor5-ui/src/input/inputbase.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/ckeditor5-ui/src/input/inputbase.ts b/packages/ckeditor5-ui/src/input/inputbase.ts index f5a91320a78..e3968f433d0 100644 --- a/packages/ckeditor5-ui/src/input/inputbase.ts +++ b/packages/ckeditor5-ui/src/input/inputbase.ts @@ -53,6 +53,7 @@ export default abstract class InputBase Date: Mon, 18 Mar 2024 14:26:36 +0100 Subject: [PATCH 3/4] Add unit test --- packages/ckeditor5-ui/tests/input/inputbase.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/ckeditor5-ui/tests/input/inputbase.js b/packages/ckeditor5-ui/tests/input/inputbase.js index 3ca5579b18e..20b8d88d4db 100644 --- a/packages/ckeditor5-ui/tests/input/inputbase.js +++ b/packages/ckeditor5-ui/tests/input/inputbase.js @@ -219,6 +219,16 @@ describe( 'InputBase', () => { } ); } ); + describe( 'tabIndex', () => { + it( 'should react on view#tabIndex', () => { + expect( view.element.getAttribute( 'tabIndex' ) ).to.be.null; + + view.tabIndex = 123; + + expect( view.element.getAttribute( 'tabIndex' ) ).to.equal( 123 ); + } ); + } ); + describe( 'aria-label', () => { it( 'should react on view#ariaLabel', () => { expect( view.element.getAttribute( 'aria-label' ) ).to.be.null; From 0583f9dde25d1a0e87e9b3dc9e3b8c01884b0434 Mon Sep 17 00:00:00 2001 From: Mateusz Baginski Date: Mon, 18 Mar 2024 14:32:41 +0100 Subject: [PATCH 4/4] incorrect unit test --- packages/ckeditor5-ui/tests/input/inputbase.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ckeditor5-ui/tests/input/inputbase.js b/packages/ckeditor5-ui/tests/input/inputbase.js index 20b8d88d4db..2bd7d748975 100644 --- a/packages/ckeditor5-ui/tests/input/inputbase.js +++ b/packages/ckeditor5-ui/tests/input/inputbase.js @@ -225,7 +225,7 @@ describe( 'InputBase', () => { view.tabIndex = 123; - expect( view.element.getAttribute( 'tabIndex' ) ).to.equal( 123 ); + expect( view.element.getAttribute( 'tabIndex' ) ).to.equal( '123' ); } ); } );