Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for license packages. #2480

Closed
TheCakeIsNaOH opened this issue Dec 3, 2021 · 3 comments
Closed

Add support for license packages. #2480

TheCakeIsNaOH opened this issue Dec 3, 2021 · 3 comments

Comments

@TheCakeIsNaOH
Copy link
Member

After some discussion with @gep13 on future plans for non-windows systems, it may make sense to create a new type of package, specifically for licenses (for licensed Chocolatey editions). Basically a .license equivalent to .extension package.

So for any package ID ending in .license, choco would check for a chocolatey.license.xml in a license directory, and copy it to $env:chocolateyinstall\license\chocolatey.license.xml. I suppose it probably should also check for chocolatey.license.xml.txt as well. Uninstall may be a bit more tricky, since what if you have multiple different .license package IDs installed? Maybe record what is the most recent license copy is?

With this in place, the package builder probably could be updated to work with this type of package, so license packages could be created automatically just by passing license file.

@corbob
Copy link
Member

corbob commented Sep 2, 2022

🤔 What about a choco license command?

Some things you could possibly do with it:

  1. choco license install ./path/to/file.extension - This could read in the file specified, verify it's a valid license, then create the appropriate directory structure and name it correctly
  2. choco license list - Get information about the currently installed license (name, license count, license type, expiration, etc.)
  3. choco license pack - Generate a chocolatey-license (or chocolatey.license package) that includes scripts to install the license.
  4. choco license uninstall - I imagine this would just remove the license file 🤷

@mkevenaar
Copy link
Contributor

🤔 What about a choco license command?

Some things you could possibly do with it:

  1. choco license install ./path/to/file.extension - This could read in the file specified, verify it's a valid license, then create the appropriate directory structure and name it correctly

  2. choco license list - Get information about the currently installed license (name, license count, license type, expiration, etc.)

  3. choco license pack - Generate a chocolatey-license (or chocolatey.license package) that includes scripts to install the license.

  4. choco license uninstall - I imagine this would just remove the license file 🤷

Related to: #2829

@TheCakeIsNaOH
Copy link
Member Author

Since the license command is going to be added (#2829), I think this can be closed, since the license installation functionality can be added there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants