Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webxdc.selfAddr not consistent for draft messages vs sent message #6621

Open
adbenitez opened this issue Mar 6, 2025 · 2 comments
Open

webxdc.selfAddr not consistent for draft messages vs sent message #6621

adbenitez opened this issue Mar 6, 2025 · 2 comments
Labels
bug Something is not working

Comments

@adbenitez
Copy link
Collaborator

when the app is in draft mode the selfAddr is always the same:

e6edc6ba5a72cef8889657b0a5212318c5c06bc2647392cf83cc27569cf9bd27

then after sending it it actually gets the real unique ID.
Can be tested with the Test Webxdc app

this causes problems like ex. if you vote in a poll before sending it or join as "waiting for player..." in a chess game before sending the app in chat

@adbenitez adbenitez added the bug Something is not working label Mar 6, 2025
@r10s
Copy link
Contributor

r10s commented Mar 6, 2025

the reason is probably that rfc724_mid is not set when get_webxdc_info() is called to query self_addr.

question is when to set rfc724_mid:

  • on set_draft() it is too late
  • maybe on get_webxdc_info(), we would need to write it back to the database then, however, which is a bit odd for a getter
  • or when creating a new message object

another option might be to remove rfc724_mid from self_addr. iirc, that was considered also that time when we moved away from email-address = self-addr

@link2xt
Copy link
Collaborator

link2xt commented Mar 6, 2025

Creating rfc724_mid already when Message is created might also be good for #6426 because every message will be uniquely identified even when it is in the draft mode.

@Septias Septias assigned Septias and unassigned Septias Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

4 participants