Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osx: enable MathBuiltinsCall.js #4537

Closed
MikeHolman opened this issue Jan 12, 2018 · 1 comment
Closed

osx: enable MathBuiltinsCall.js #4537

MikeHolman opened this issue Jan 12, 2018 · 1 comment
Assignees
Milestone

Comments

@MikeHolman
Copy link
Contributor

MikeHolman commented Jan 12, 2018

Not sure how much we care, but for example, Math.atan(10) is 1.4711276743037344 on OSX. On other platforms it equals 1.4711276743037347.

Opened as result of test failure in #4531

@obastemur
Copy link
Collaborator

some tips;

Test: https://github.com/Microsoft/ChakraCore/blob/master/test/AsmJs/MathBuiltinsCall.js

The test file looks useful for testing math builtins and we may compare atan result per platform if it's necessary:

var isMac = (WScript.Platform && WScript.Platform.OS == 'darwin');

The line above is to check if the host OS is a mac.

@obastemur obastemur changed the title Math.atan sometimes gives different result on OSX than on other platforms osx: enable MathBuiltinsCall.js Jan 25, 2018
@obastemur obastemur added this to the 1.8 milestone Feb 8, 2018
chakrabot pushed a commit that referenced this issue Feb 9, 2018
…t for OSX

Merge pull request #4653 from obastemur:enable_math_Builtins_osx

Fixes #4537
chakrabot pushed a commit that referenced this issue Feb 10, 2018
…ltinsCall test for OSX

Merge pull request #4653 from obastemur:enable_math_Builtins_osx

Fixes #4537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants