From 5bc4ba8bd52b5071516bc0cbe95442f4fc31328d Mon Sep 17 00:00:00 2001 From: "Dr. David A. Kunz" Date: Tue, 10 Sep 2024 10:06:02 +0200 Subject: [PATCH 1/3] fix(deep-queries): properly return insert result --- db-service/lib/deep-queries.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db-service/lib/deep-queries.js b/db-service/lib/deep-queries.js index 2fdbf1041..25d5312b4 100644 --- a/db-service/lib/deep-queries.js +++ b/db-service/lib/deep-queries.js @@ -61,7 +61,7 @@ async function onDeep(req, next) { ...Array.from(queries.inserts.values()).map(query => this.onINSERT({ query })), ]) - return beforeData.length ?? rootResult + return rootResult ?? beforeData.length } const hasDeep = (q, target) => { From 0f83b94cc60a5806e64dd187f4a5f3d8e095e40a Mon Sep 17 00:00:00 2001 From: "Dr. David A. Kunz" Date: Tue, 10 Sep 2024 10:13:31 +0200 Subject: [PATCH 2/3] added test --- db-service/test/deep/deep.test.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/db-service/test/deep/deep.test.js b/db-service/test/deep/deep.test.js index 114a6bec9..9a819a7a9 100644 --- a/db-service/test/deep/deep.test.js +++ b/db-service/test/deep/deep.test.js @@ -831,7 +831,8 @@ describe('test deep query generation', () => { const insert = INSERT.into(entity).entries(entry) - await cds.db.run(insert) + const [...result] = await cds.db.run(insert) + expect(result).toMatchObject([{ realm: 'dummy', uniqueName: 'PR1'}]) const root = { uniqueName: entry.uniqueName, realm: entry.realm } From a4a5bd45b5ecabccec4d9ba2f344254b1b4bfae8 Mon Sep 17 00:00:00 2001 From: "Dr. David A. Kunz" Date: Tue, 10 Sep 2024 10:47:07 +0200 Subject: [PATCH 3/3] . --- db-service/test/deep/deep.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/db-service/test/deep/deep.test.js b/db-service/test/deep/deep.test.js index 9a819a7a9..c571af185 100644 --- a/db-service/test/deep/deep.test.js +++ b/db-service/test/deep/deep.test.js @@ -831,8 +831,8 @@ describe('test deep query generation', () => { const insert = INSERT.into(entity).entries(entry) - const [...result] = await cds.db.run(insert) - expect(result).toMatchObject([{ realm: 'dummy', uniqueName: 'PR1'}]) + const result = await cds.db.run(insert) + expect(result > 0).toBe(true) const root = { uniqueName: entry.uniqueName, realm: entry.realm }