Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Leakz passive workflow #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dwisiswant0
Copy link

Please ensure your pull request adheres to the following guidelines:

Thanks for contributing!

@dwisiswant0 dwisiswant0 force-pushed the dwisiswant0/feat/add-leakz-passive-workflow branch from cb03fe6 to 395bf56 Compare April 22, 2024 17:15
Signed-off-by: Dwi Siswanto <[email protected]>
Signed-off-by: Dwi Siswanto <[email protected]>
@Corb3nik
Copy link
Contributor

Corb3nik commented May 6, 2024

Finally found time to check this out, looking forward to merging this one.

The workflow seems to be causing my CPU to go up to 100% + websites become super slow to load.

@dwisiswant0 Is that something you can improve on your end?

@dwisiswant0
Copy link
Author

dwisiswant0 commented May 6, 2024

@Corb3nik - It seems my CPU isn't experiencing any excessive load, and just to note, I'm operating on Linux x86.

About the slow-loading sites you mentioned, I've noticed it too during my casual browsing. Ran some regression tests with projectdiscovery/katana, and all seems cool from my side. Can't figure out why it's acting up though, especially since it's just using the RegExp constructor.

@Sytten
Copy link
Contributor

Sytten commented May 7, 2024

The JS VM is not very performant/optimized, but I will start offloading the compute to other threads to relieve the proxy.
Down the line plugins like those which are compute intensive should be moved to WASM so they run native bytecode instead of a VM.

@Sytten
Copy link
Contributor

Sytten commented May 15, 2024

Sorry we didnt get back to you faster @dwisiswant0 , before we can approve the merge we need a couple things:

  1. The original source code of the script node, I updated the Template to reflect that.
  2. If you want to add a source URL you can do so to reference your own Github project

@dwisiswant0
Copy link
Author

  1. I updated the Template to reflect that.

Ok, then how can I include the compiled sources in the Workflow JSON?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants