Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package #1

Open
dkniffin opened this issue Oct 23, 2020 · 9 comments
Open

npm package #1

dkniffin opened this issue Oct 23, 2020 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dkniffin
Copy link

I'm searching around the internet for dismissible alert libraries and this seems to be one of the only ones! I'm not sure if I'm going to use it yet or not, since it looks like it's brand new and not very popular yet, but for anyone who does, an npm package install would help a lot.

@brookesb91
Copy link
Owner

I'm searching around the internet for dismissible alert libraries and this seems to be one of the only ones! I'm not sure if I'm going to use it yet or not, since it looks like it's brand new and not very popular yet, but for anyone who does, an npm package install would help a lot.

Apologies for the delay in response. I can certainly work to make that happen!

@brookesb91 brookesb91 added enhancement New feature or request help wanted Extra attention is needed labels Feb 16, 2021
@brookesb91
Copy link
Owner

I'm searching around the internet for dismissible alert libraries and this seems to be one of the only ones! I'm not sure if I'm going to use it yet or not, since it looks like it's brand new and not very popular yet, but for anyone who does, an npm package install would help a lot.

Quick update, I've made the package available and installable from GitHub

$ npm i https://github.com/brookesb91/dismissible/releases/download/v1.0.0/dismissible-1.0.0.tgz

I will be working towards hosting on NPM when I've the time, but I hope that helps for now!

@dkniffin
Copy link
Author

dkniffin commented Feb 17, 2021

fwiw, I ended up going a different route for my needs

@brookesb91
Copy link
Owner

fwiw, I ended up going a different route for my needs

Not at all a problem 😊

@sshaw
Copy link

sshaw commented Jan 13, 2022

Looking at this library too. Looks promising but I would highly recommend:

  1. Creating an actual npm package, e.g., npm i dismissible
  2. Turning the demo directory into a GitHub page
  3. Adding supported browser and color customization info to the docs (looks like at least no IE since CSS vars are used —which is fine but, would be good to know upfront)

1 & 2 will help people find it and the demo site will allow folks to quickly get a feel for the package. Often times people will only search npm.

@sshaw
Copy link

sshaw commented Jan 13, 2022

@dkniffin what did you end up using?

@brookesb91
Copy link
Owner

Looking at this library too. Looks promising but I would highly recommend:

  1. Creating an actual npm package, e.g., npm i dismissible
  2. Turning the demo directory into a GitHub page
  3. Adding supported browser and color customization info to the docs (looks like at least no IE since CSS vars are used —which is fine but, would be good to know upfront)

1 & 2 will help people find it and the demo site will allow folks to quickly get a feel for the package. Often times people will only search npm.

Thanks for the advice.

I hadn't used the npm namespace prior because it was taken at the time I made this library. Looks like it's free now so I will make that a consideration.
I will definitely be addressing the demo and changing it to work with GitHub pages.
I agree more documentation is required. This was meant to just be a quick archival of the pen I made here.

If there is anything pressing you may need, feel free to open up an issue. I'm also open to contributions :)

@brookesb91 brookesb91 reopened this Jan 13, 2022
@brookesb91
Copy link
Owner

I will reopen this issue until the new npm package has been published.

@brookesb91 brookesb91 added the good first issue Good for newcomers label Jan 13, 2022
@dkniffin
Copy link
Author

I just wrote some custom JS and CSS I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants