Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serious Error!!!! #2

Open
Hiiragizawa opened this issue Oct 28, 2019 · 0 comments
Open

Serious Error!!!! #2

Hiiragizawa opened this issue Oct 28, 2019 · 0 comments

Comments

@Hiiragizawa
Copy link

Found a very serious error in this code, when you use gap_open = -5, gap_extend = -1, the alignment is meaningless( works fine if you don't put any). I tried to do the same in the old version (0.3.0 that works in python2), attached the results:

  • Your nwaling version:

import nwaling3
nwalign3.global_align("SHMYAPKLQGPVAVYTWEGNQVNITCEVFAYPSATISWFRDGQLLPSSNYSNIKIYNTPSASYLEVTPDSENDFGNYNCTAVNRIGQESLEFILVQADTPSSPSIDQVEPYSSTAQVQFDEPEATGGVPILKYKAEWRAVGEEVWHSKWYDAKEASMEGIVTIVGLKPETTYAVRLAALNGKGLGEISAASEFKTQP", "SVAPTMMNVLYAGIDNPINIAVPGVAQQNVSATINNGTLTRRGNLWIARPTKVGSEAIISVTAQSGGRTIQMAKTTLRVRALPDPLPYIEYKDVQGNTKRFKGGRLGKREILAAGGIKAALDDDLLEVNYTVVKFQLVFYDSMGNSIPEVSDGASFSERQKRQIQNLGKGKRFYVTEVIARGPDGIERKIPAIEVIVN",gap_open=-5,gap_extend=-1, matrix='BLOSUM62')

OUTPUT:('---------------------------SHMYAPKLQ-GPVAVYTWEGNQ-V-NITCEVFAYPSATIS-WFRDG-QLLPSSNYSNIKIYNTPSA-SYLEVTPDSENDFGNYN-CTAVNRIGQESLEFILVQADTPSSPSIDQ-V-EP-YSSTAQVQFDEPEATGGVPILKYKAEWRAVGEEVWHSKWYDAKEASMEGIVTIVGLKPETTYAVRLAALNGK-GLGE--ISAASEFKTQP', 'SVAPTMMNVLYAGIDNPINIAVPGVAQQNVSAT-INNG-T-L-TRRGNLWIARPT-KV-G-SEAIISVTAQSGGRTIQMAK-TTLRVRALPDPLPYIEYK-DVQ---GNTKRFKG-GRLGKR--E-ILA-AGGIKA-ALDDDLLEVNY--TV-VKF-Q------L-VF-YDSMGNSI-PEVSDGASFSERQ-KRQ-IQNL-G-KGKRFYVTEVIA-RGPDGI-ERKIPAI-EVIVN-')

  • The older one:

nwalign.global_align("SHMYAPKLQGPVAVYTWEGNQVNITCEVFAYPSATISWFRDGQLLPSSNYSNIKIYNTPSASYLEVTPDSENDFGNYNCTAVNRIGQESLEFILVQADTPSSPSIDQVEPYSSTAQVQFDEPEATGGVPILKYKAEWRAVGEEVWHSKWYDAKEASMEGIVTIVGLKPETTYAVRLAALNGKGLGEISAASEFKTQP", "SVAPTMMNVLYAGIDNPINIAVPGVAQQNVSATINNGTLTRRGNLWIARPTKVGSEAIISVTAQSGGRTIQMAKTTLRVRALPDPLPYIEYKDVQGNTKRFKGGRLGKREILAAGGIKAALDDDLLEVNYTVVKFQLVFYDSMGNSIPEVSDGASFSERQKRQIQNLGKGKRFYVTEVIARGPDGIERKIPAIEVIVN",gap_open=-5,gap_extend=-1, matrix='/BLOSUM62')

OUTPUT: ('SHMYAPKLQGPVAVYTWEGNQVNITCEVFAYP--SATISWFRDGQLLPSSNYSNIKIYNTPSASYLEVTPDSENDFGNYNCTAVN-RIGQESLEFI-L--VQADTPS-SPS-IDQVEPYSSTA-QVQFDEPEATGGVPILKYKAE-WRAVGEEVWH-SKWYDAKEASMEGIVTIVGLKPETTYAVRLAALNGK-GLG-EISAASEFKTQP', 'S--VAPTMMN-V-LYAGIDNPINIAVPGVAQQNVSATIN---NGTLTRRGNLWIARPTKVGSEAIISVTAQSGGRTIQMAKTTLRVRALPDPLPYIEYKDVQGNTKRFKGGRLGKREILAAGGIKAALDDDLLEVNYTVVKFQLVFYDSMGNSIPEVSDGASFSERQKRQIQNL-G-KGKRFYVTEVIA-RGPDGIERKIPAI-EVIVN-')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant