Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run <script> in containers when pjax loaded #4

Open
moeshin opened this issue Oct 10, 2021 · 2 comments
Open

Run <script> in containers when pjax loaded #4

moeshin opened this issue Oct 10, 2021 · 2 comments
Labels
enhancement

Comments

@moeshin
Copy link

moeshin commented Oct 10, 2021 

<body>
<script>alert('hi')</script>
</body>
Pjax.start({
    containers: ['body']
});
@moeshin
Copy link
Author

moeshin commented Oct 10, 2021

like: https://github.com/MoOx/pjax/blob/480334b18253c721ba648675e90261f948e2bca0/lib/eval-script.js

@brcontainer
Copy link
Owner

@moeshin Thanks for the helpful advice. When I created the library I thought of implementing this using documentgetElementsByTagNameScript, but at the time it seemed to me that it would be better to create an event to detect route changes, as in the example:

document.addEventListener("pjax:complete", function() {
  console.log("Event: pjax:complete", arguments);
});

I still intend to implement (it will be a feature that can be disabled). I will notify you shortly with the lib update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brcontainer @moeshin