Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

pinned tab is incorrectly selected after closing 2nd tab of 2-tab window #1562

Closed
bradleyrichter opened this issue May 4, 2016 · 5 comments
Assignees

Comments

@bradleyrichter
Copy link
Contributor

STR

open a new window
make sure it has pinned tabs
use first normal tab
make a new tab
use the new tab (ie: google search)
close that tab with command+W

result: right-most pinned tab becomes selected instead of first tab to the left

this happens regardless of which tab was last selected before tab closure

expected: last active tab should be selected after closing newer tab

@bradleyrichter bradleyrichter added this to the 0.9.4dev milestone May 4, 2016
@bbondy bbondy modified the milestones: 0.10.1dev, 0.10.0dev May 8, 2016
@bbondy bbondy modified the milestones: 0.10.1dev, 0.10.0dev May 15, 2016
@bbondy bbondy removed this from the 0.10.1dev milestone May 26, 2016
@cezaraugusto
Copy link
Contributor

@bradleyrichter I think it's already fixed. Does it still happening to you?

@cezaraugusto cezaraugusto added the needs-info Another team member needs information from the PR/issue opener. label Jul 21, 2016
@bradleyrichter
Copy link
Contributor Author

@cezaraugusto

still happens on current master branch

@bradleyrichter
Copy link
Contributor Author

Maybe it's now a mac-only issue?

@bsclifton
Copy link
Member

bsclifton commented Jul 22, 2016

I had made a fix recently which should be preventing this:
#2333

Self assigning- I can dig into this tonite (but others are more than welcome to check it out in the meantime cc: @cezaraugusto)

@bsclifton bsclifton self-assigned this Jul 22, 2016
@bsclifton
Copy link
Member

I believe this was fixed w/ #2923

I tried the steps above with the current master branch (trying the steps in my initial window, in a new window, and all kinds of variations). I'm unable to reproduce

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants