From 768d352d2fea8ce76e1d0cb5f0bde86c5f73c222 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Fri, 7 May 2021 23:52:28 +0200 Subject: [PATCH] refactor(protractor): better naming for server runfiles in rule (#2644) Follow-up to 4965db6b775d99c370fe0fad7582168d55d520ec. Improves the naming of the server runfiles depset. --- packages/protractor/protractor_web_test.bzl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/protractor/protractor_web_test.bzl b/packages/protractor/protractor_web_test.bzl index bd5653988a..76eeefbfa2 100644 --- a/packages/protractor/protractor_web_test.bzl +++ b/packages/protractor/protractor_web_test.bzl @@ -110,12 +110,12 @@ def _protractor_web_test_impl(ctx): ) runfiles = [configuration] + configuration_sources + on_prepare_sources - server_files = depset() + server_runfiles = depset() # If a server has been specified, add it to the runfiles together with it's required runfiles. This is necessary # as the test executable references the server executable as per `TMPL_server` and executes it. if ctx.executable.server: - server_files = depset( + server_runfiles = depset( [ctx.executable.server], transitive = [ctx.attr.server[DefaultInfo].default_runfiles.files], ) @@ -175,7 +175,7 @@ ${{COMMAND}} files = depset([ctx.outputs.script]), runfiles = ctx.runfiles( files = runfiles, - transitive_files = depset(transitive = [files, node_modules, server_files]), + transitive_files = depset(transitive = [files, node_modules, server_runfiles]), # Propagate protractor_bin and its runfiles collect_data = True, collect_default = True,