Skip to content

Commit 4c379d2

Browse files
author
Alex Eagle
committed
fix(builtin): only pass kwargs to the test, not the .update binary
This allows you to set things like size or timeout to prevent warnings under bazel test --test_verbose_timeout_warnings
1 parent 2a9abfc commit 4c379d2

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

internal/generated_file_test/generated_file_test.bzl

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
1616
anywhere within the generated file. Note that the .update rule is not generated in substring mode.
1717
src_dbg: if the build uses `--compilation_mode dbg` then some rules will produce different output.
1818
In this case you can specify what the dbg version of the output should look like
19-
**kwargs: extra arguments passed to the underlying nodejs_test or nodejs_binary
19+
**kwargs: extra arguments passed to the underlying nodejs_test
2020
"""
2121
data = [src, generated]
2222

@@ -46,5 +46,4 @@ def generated_file_test(name, generated, src, substring_search = False, src_dbg
4646
entry_point = "@build_bazel_rules_nodejs//internal/generated_file_test:bundle.js",
4747
templated_args = ["--out", loc % src, loc % src_dbg, loc % generated],
4848
data = data,
49-
**kwargs
5049
)

0 commit comments

Comments
 (0)