Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an Output to a stack does not count as a change so the stack is not deployed #186

Closed
rix0rrr opened this issue Jun 28, 2018 · 9 comments
Assignees
Labels
bug This issue is a bug. good first issue Related to contributions. See CONTRIBUTING.md

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 28, 2018

Reproduction

Have a stack, deploy it. Add an Output object to it. Deploy it again.

Expectation

Stack is deployed and the Output is added.

Reality

 ⏳  Starting deployment of stack XXXX...
 ✅  Stack was already up-to-date, it has ARN XXXXXX
@rix0rrr rix0rrr added bug This issue is a bug. good first issue Related to contributions. See CONTRIBUTING.md labels Jun 28, 2018
@RomainMuller
Copy link
Contributor

Isn't this CloudFormation behavior?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 29, 2018

Might be, but it's still surprising behavior from the user's PoV.

@RomainMuller
Copy link
Contributor

I am not denying that. Just wanted to make sure.

@coderbyheart
Copy link
Contributor

No, if you add an output and deploy it using cloud formation (CLI or Web UI) the output is added.

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Sep 7, 2018

You are right, what Romain was referring to I think is the ChangeSet that is created in the process showing "no changes" (at least at the resource level). We're interpreting that response as "nothing to do", and hence doing nothing.

@ijcd
Copy link

ijcd commented Nov 14, 2018

I'm hitting this as well. Is there a workaround?

@eladb
Copy link
Contributor

eladb commented Nov 15, 2018

@ijcd make some other change to the template such as adding metadata.

@eladb
Copy link
Contributor

eladb commented Apr 2, 2019

@rix0rrr this is resolved, correct?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Apr 2, 2019

Yes, was fixed in #2029

@rix0rrr rix0rrr closed this as completed Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. good first issue Related to contributions. See CONTRIBUTING.md
Projects
None yet
Development

No branches or pull requests

5 participants