Skip to content
This repository was archived by the owner on Dec 28, 2017. It is now read-only.

brew upgrade is broken #20

Closed
natemcmaster opened this issue Jun 25, 2015 · 16 comments
Closed

brew upgrade is broken #20

natemcmaster opened this issue Jun 25, 2015 · 16 comments
Assignees

Comments

@natemcmaster
Copy link

brew upgrade dnvm should actually update DNVM on Mac. The current recipe does not actually update with dnvm changes. Add a version number to the recipe so brew will notice changes.

Without this, it appears to users the DNVM is updated, even when its not. This leads to other issues, such as aspnet/dnx#2126.

Even when aspnet/dnvm#246 is resolved, brew upgrade is more familiar upgrade path for users.

** Workaround **

brew remove dnvm
brew update
brew install dnvm
@muratg
Copy link
Contributor

muratg commented Jun 29, 2015

@davidfowl Should we just remove homebrew installer and use Curl or something to do the initial installation?

@natemcmaster
Copy link
Author

Brew is very popular. I think it's worth keeping. Just my 2 cents.

@muratg
Copy link
Contributor

muratg commented Jul 1, 2015

I love brew myself, it's great for a lot of things. But installing a version manager with a package manager is a little weird.

For example, there's no official brew formula for nvm (see the discussion) and on their Readme they recommend curl or wget to install it.

@natemcmaster
Copy link
Author

Yeah, it is strange. Also RVM doesn't use brew. I believe we used setup this repo because it makes installing mono easier.

@analogrelay
Copy link
Contributor

Yeah, it's mostly about Mono. We did it so that the kvm (at the time) recipe could depend on the right Mono package. As Mono is stabilizing a little bit (and we're getting CoreCLR on Mac up and running) it's probably time to look at moving away from brew. I'm with @muratg, I love brew but it isn't quite right for what we're trying to do here. We could return to brew when we build installers for Mac/Linux that are focused more on production systems (i.e. where dnvm is less interesting). I know @glennc has played with building a Mac OS X pkg installer, we could have a similar brew installer for the dnx itself (rather than for dnvm)

@muratg
Copy link
Contributor

muratg commented Jul 6, 2015

@davidfowl time to pull the plug for brew formula for dnvm? :)

@analogrelay
Copy link
Contributor

My suggestion would be to ensure the curl script works on Mac (I think I tried it once and it worked fine) and change the Home repo instructions to that. Then, possibly, deprecate the Brew formula by printing a warning message or something (not sure if brew has a deprecation mechanism)

@muratg muratg added this to the 1.0.0-beta6 milestone Jul 7, 2015
@natemcmaster
Copy link
Author

This worked just fine for me too.

curl -sSL https://raw.githubusercontent.com/aspnet/Home/dev/dnvminstall.sh | bash

I suggest adding a line to dnvminstall.sh to source dnvm.sh right away to make it dnvm instantly accessible.

@natemcmaster
Copy link
Author

@anurse AFAIK there is no deprecation flag for brew. Probably better to remove the formula altogether.

@analogrelay
Copy link
Contributor

@natemcmaster Unfortunately, because the dnvminstall.sh script is run in a sub-process, having it call source dnvm.sh would not actually work. dnvm would be loaded into the sub-process which would immediately exit. We can probably put it in the command line though, something like curl -sSL https://raw.githubusercontent.com/aspnet/Home/dev/dnvminstall.sh | bash && source ~/.dnx/bin/dnvm.sh

As for deprecating/removing the brew formula, I thought that might be the case. I agree that removing it will probably be best.

@analogrelay
Copy link
Contributor

What's the work item here @muratg ? To me it sounds like:

  1. Remove the DNVM formula from Homebrew, or replace it with an error or something
  2. Update docs.asp.net and Home to use the curl command.

@muratg
Copy link
Contributor

muratg commented Jul 15, 2015

@anurse yup, and test the curl command to make sure. When we update the documentation, we should also recommend a Mono version to install (and possibly a link)

@analogrelay
Copy link
Contributor

Ok, sounds good!

@analogrelay
Copy link
Contributor

Confirmed that the curl command works fine on Mac. I'll work on some documentation updates for the Mac process.

@muratg
Copy link
Contributor

muratg commented Jul 17, 2015

Looks like we're placing dnvm in ~/.dnx/dnvm these days. Make sure to update the command line to reflect that :)

@analogrelay
Copy link
Contributor

Yep.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants