-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not learning reward? #42
Comments
cannot reproduce the results presented by the paper on D4RL benchmark when using the learned reward model. |
Hi, |
I may have a solution. In the readme, it suggests to change the configuration file putting 'learn_reward' = True and 'reward_file' = None. If you put 'reward_file' = None the execution stops due to an error. What I find is to keep the 'reward_file' field, but comment out the reward function contained in there. If you simply comment the 'reward_file' flag, you will also delete the termination function used for the rollouts. |
Hi,
In the original code base, the algo does not learn the reward function, instead, the agent computes cumulative reward using the true reward function (directly get from env). Meaning we are actually using some true information from the environment, is that allowed in the offline setting? Also, after changing the 'learn_reward' option to True in the config file, the performance is much worse.
The text was updated successfully, but these errors were encountered: