From eedf0775607bd94a1d38863e4dc145125bee89bb Mon Sep 17 00:00:00 2001 From: Junda Yang Date: Mon, 26 Nov 2018 11:21:53 -0800 Subject: [PATCH 1/2] revert 848 --- superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx | 2 +- superset/assets/src/SqlLab/components/ResultSet.jsx | 2 +- superset/assets/src/SqlLab/constants.js | 1 - superset/assets/src/SqlLab/reducers/sqlLab.js | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx b/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx index 295c32f8bb657..1e9fe05e1b6c8 100644 --- a/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx +++ b/superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx @@ -26,7 +26,7 @@ class QueryAutoRefresh extends React.PureComponent { return ( queriesLastUpdate > 0 && Object.values(queries).some( - q => ['running', 'started', 'pending', 'fetching', 'rendering'].indexOf(q.state) >= 0 && + q => ['running', 'started', 'pending', 'fetching'].indexOf(q.state) >= 0 && now - q.startDttm < MAX_QUERY_AGE_TO_POLL, ) ); diff --git a/superset/assets/src/SqlLab/components/ResultSet.jsx b/superset/assets/src/SqlLab/components/ResultSet.jsx index 41ced6dcb03a6..c950005262f61 100644 --- a/superset/assets/src/SqlLab/components/ResultSet.jsx +++ b/superset/assets/src/SqlLab/components/ResultSet.jsx @@ -213,7 +213,7 @@ export default class ResultSet extends React.PureComponent { } let progressBar; let trackingUrl; - if (query.progress > 0) { + if (query.progress > 0 && query.state === 'running') { progressBar = ( Date: Mon, 17 Dec 2018 11:51:14 -0800 Subject: [PATCH 2/2] nit --- superset/assets/src/SqlLab/components/ResultSet.jsx | 2 +- superset/assets/src/SqlLab/reducers/sqlLab.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/assets/src/SqlLab/components/ResultSet.jsx b/superset/assets/src/SqlLab/components/ResultSet.jsx index c950005262f61..41ced6dcb03a6 100644 --- a/superset/assets/src/SqlLab/components/ResultSet.jsx +++ b/superset/assets/src/SqlLab/components/ResultSet.jsx @@ -213,7 +213,7 @@ export default class ResultSet extends React.PureComponent { } let progressBar; let trackingUrl; - if (query.progress > 0 && query.state === 'running') { + if (query.progress > 0) { progressBar = (