From 9704bea1fd824f198103745af15528ee91251e82 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Tue, 10 Apr 2018 14:46:19 -0700 Subject: [PATCH] [bugfix] dedup groupby columns in Deck visualizations When specifying the same column twice as a `Extra Data for JS` and `Categorical Color`, an error is issued. This addresses this issue. --- superset/viz.py | 1 + 1 file changed, 1 insertion(+) diff --git a/superset/viz.py b/superset/viz.py index 87dd1a9ebe01c..dbfcdcc9b72f3 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -2019,6 +2019,7 @@ def query_obj(self): if fd.get('js_columns'): gb += fd.get('js_columns') metrics = self.get_metrics() + gb = list(set(gb)) if metrics: d['groupby'] = gb d['metrics'] = self.get_metrics()