Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to add some chart style, such as linePlusBarChart, multiBarHorizontalChart, multiChart #1768

Closed
ujhujuh opened this issue Dec 6, 2016 · 8 comments

Comments

@ujhujuh
Copy link

ujhujuh commented Dec 6, 2016

Make sure these boxes are checked before submitting your issue - thank you!

  • [yes ] I have checked the superset logs for python stacktraces and included it here as text if any
  • [yes ] I have reproduced the issue with at least the latest released version of superset
  • [yes] I have checked the issue tracker for the same issue and I haven't found one similar

In our project , we enhance the viz that add some chart style : linePlusBarChart, multiBarHorizontalChart, multiChart.
we can get the chart like that:
a
b
c

Superset version

0.14.1

Expected results

1.linePlusBarChart
2. multiBarHorizontalChart,
3.multiChart.

Actual results

fine

Steps to reproduce

New feature.

later, I will submit the code, ,if you think my code is okay, could you please merge pull reqiest?

@mistercrunch
Copy link
Member

note that we have the explorev2 refactor going on (to be merged probably end of week), until it's merged you need to make the changes in 2 places (explore and explorev2).

From the screenshot about, the 3rd chart looks pretty unreadable...

the 2nd chart seems like it could just be a new is_horizontal option added to the existing bar chart (if the api is similar enough)

@ujhujuh
Copy link
Author

ujhujuh commented Dec 6, 2016

@mistercrunch
i think the 3nd chart is necessary,I was able to get any charts I wanted。
It looks unreadable because there are too many charts, you can choose what you want.
like that:
d
e

@desavera
Copy link

This would be GREAT !

@gremney
Copy link

gremney commented Sep 1, 2017

This looks amazing. I am using version 0.19 but seems could not reproduce the above. I am also unable to locate the "chart options" in superset, could you please advise? Appreciated.

@shyam2794
Copy link

@ujhujuh This looks great and will be very much usefull in our current project. Can you please document the steps how you have implemented this, it will be much helpfull .

@mistercrunch
Copy link
Member

FYI we're considering [longer term] to move our core charts to using data-ui which is built on vx. These charts are very "composable" meaning we could add better support for multi-layered charts at that point. Until then I don't think we want to add much more support for multi-layered-charts.

@mistercrunch
Copy link
Member

Notice: this issue has been closed because it has been inactive for 199 days. Feel free to comment and request for this issue to be reopened.

@kristw
Copy link
Contributor

kristw commented Feb 13, 2019

#6812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants