diff --git a/.pylintrc b/.pylintrc index be82d9d542d6c..6e213c4831a3c 100644 --- a/.pylintrc +++ b/.pylintrc @@ -65,7 +65,7 @@ confidence= # --enable=similarities". If you want to run only the classes checker, but have # no Warning level messages displayed, use"--disable=all --enable=classes # --disable=W" -disable=standarderror-builtin,long-builtin,dict-view-method,intern-builtin,suppressed-message,no-absolute-import,unpacking-in-except,apply-builtin,delslice-method,indexing-exception,old-raise-syntax,print-statement,cmp-builtin,reduce-builtin,useless-suppression,coerce-method,input-builtin,cmp-method,raw_input-builtin,nonzero-method,backtick,basestring-builtin,setslice-method,reload-builtin,oct-method,map-builtin-not-iterating,execfile-builtin,old-octal-literal,zip-builtin-not-iterating,buffer-builtin,getslice-method,metaclass-assignment,xrange-builtin,long-suffix,round-builtin,range-builtin-not-iterating,next-method-called,dict-iter-method,parameter-unpacking,unicode-builtin,unichr-builtin,import-star-module-level,raising-string,filter-builtin-not-iterating,old-ne-operator,using-cmp-argument,coerce-builtin,file-builtin,old-division,hex-method,invalid-unary-operand-type +disable=standarderror-builtin,long-builtin,dict-view-method,intern-builtin,suppressed-message,no-absolute-import,unpacking-in-except,apply-builtin,delslice-method,indexing-exception,old-raise-syntax,print-statement,cmp-builtin,reduce-builtin,useless-suppression,coerce-method,input-builtin,cmp-method,raw_input-builtin,nonzero-method,backtick,basestring-builtin,setslice-method,reload-builtin,oct-method,map-builtin-not-iterating,execfile-builtin,old-octal-literal,zip-builtin-not-iterating,buffer-builtin,getslice-method,metaclass-assignment,xrange-builtin,long-suffix,round-builtin,range-builtin-not-iterating,next-method-called,dict-iter-method,parameter-unpacking,unicode-builtin,unichr-builtin,import-star-module-level,raising-string,filter-builtin-not-iterating,old-ne-operator,using-cmp-argument,coerce-builtin,file-builtin,old-division,hex-method,invalid-unary-operand-type,missing-docstring,too-many-lines,duplicate-code [REPORTS] diff --git a/superset/__init__.py b/superset/__init__.py index 929fcfe621384..2c3957b7d6dc8 100644 --- a/superset/__init__.py +++ b/superset/__init__.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """Package's main module!""" from __future__ import absolute_import from __future__ import division diff --git a/superset/cache_util.py b/superset/cache_util.py index be6b6d5d742c3..d456f6601d9ba 100644 --- a/superset/cache_util.py +++ b/superset/cache_util.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/cli.py b/superset/cli.py index 6321b5f18dbad..d31e0033fbe52 100755 --- a/superset/cli.py +++ b/superset/cli.py @@ -1,5 +1,6 @@ #!/usr/bin/env python # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/config.py b/superset/config.py index 8a1b1063732af..530b1268962ac 100644 --- a/superset/config.py +++ b/superset/config.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """The main config file for Superset All configuration in this file can be overridden by providing a superset_config diff --git a/superset/connectors/base/models.py b/superset/connectors/base/models.py index 9f9522daa45b0..b306299ccfeb0 100644 --- a/superset/connectors/base/models.py +++ b/superset/connectors/base/models.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/connectors/base/views.py b/superset/connectors/base/views.py index 7d54dcf22edc7..ffec806389382 100644 --- a/superset/connectors/base/views.py +++ b/superset/connectors/base/views.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/connectors/connector_registry.py b/superset/connectors/connector_registry.py index 79f876acf2da5..efafcb441739c 100644 --- a/superset/connectors/connector_registry.py +++ b/superset/connectors/connector_registry.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/connectors/druid/models.py b/superset/connectors/druid/models.py index 26e3c721a0e29..4ff5e5fa09c86 100644 --- a/superset/connectors/druid/models.py +++ b/superset/connectors/druid/models.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W # pylint: disable=invalid-unary-operand-type from __future__ import absolute_import from __future__ import division diff --git a/superset/connectors/druid/views.py b/superset/connectors/druid/views.py index d5401caf92986..82cd46215fe84 100644 --- a/superset/connectors/druid/views.py +++ b/superset/connectors/druid/views.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py index 56a1751243995..9d6f57b4554dc 100644 --- a/superset/connectors/sqla/models.py +++ b/superset/connectors/sqla/models.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py index 2b8da0e45ab3e..2f1ef8d7271db 100644 --- a/superset/connectors/sqla/views.py +++ b/superset/connectors/sqla/views.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """Views used by the SqlAlchemy connector""" from __future__ import absolute_import from __future__ import division diff --git a/superset/data/__init__.py b/superset/data/__init__.py index 8ad6c11688a11..30b588f020d53 100644 --- a/superset/data/__init__.py +++ b/superset/data/__init__.py @@ -1,4 +1,5 @@ """Loads datasets, dashboards and slices in a new superset instance""" +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/dataframe.py b/superset/dataframe.py index 38c4fb535f2e6..79a2c3d564bdf 100644 --- a/superset/dataframe.py +++ b/superset/dataframe.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """ Superset wrapper around pandas.DataFrame. TODO(bkyryliuk): add support for the conventions like: *_dim or dim_* diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py index 49dd39cd6d4aa..e95b4d3928c19 100644 --- a/superset/db_engine_specs.py +++ b/superset/db_engine_specs.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """Compatibility layer for different database engines This modules stores logic specific to different database engines. Things diff --git a/superset/db_engines/hive.py b/superset/db_engines/hive.py index 4f677faefb33e..9a144e8dd69a0 100644 --- a/superset/db_engines/hive.py +++ b/superset/db_engines/hive.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/dict_import_export_util.py b/superset/dict_import_export_util.py index 4f7660ec84ceb..3bdfcd933ae9d 100644 --- a/superset/dict_import_export_util.py +++ b/superset/dict_import_export_util.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/exceptions.py b/superset/exceptions.py index 569a74b0eda4d..0a27b514a84fe 100644 --- a/superset/exceptions.py +++ b/superset/exceptions.py @@ -1,5 +1,5 @@ # -*- coding: utf-8 -*- - +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/extract_table_names.py b/superset/extract_table_names.py index 8cac1e1ee43e2..becfdcd800565 100644 --- a/superset/extract_table_names.py +++ b/superset/extract_table_names.py @@ -1,5 +1,6 @@ #!/usr/bin/env python # -*- coding: utf-8 -*- +# pylint: disable=C,R,W # # Copyright (C) 2016 Andi Albrecht, albrecht.andi@gmail.com # diff --git a/superset/forms.py b/superset/forms.py index e846d57ca9991..0537ded3e4167 100644 --- a/superset/forms.py +++ b/superset/forms.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """Contains the logic to create cohesive forms on the explore view""" from __future__ import absolute_import from __future__ import division diff --git a/superset/import_util.py b/superset/import_util.py index 877cb90020c06..869340490382a 100644 --- a/superset/import_util.py +++ b/superset/import_util.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/jinja_context.py b/superset/jinja_context.py index ce8795acf2b15..b700515284bcb 100644 --- a/superset/jinja_context.py +++ b/superset/jinja_context.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """Defines the templating context for SQL Lab""" from __future__ import absolute_import from __future__ import division diff --git a/superset/legacy.py b/superset/legacy.py index 88d75709967cd..7af89b21a5cb4 100644 --- a/superset/legacy.py +++ b/superset/legacy.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """Code related with dealing with legacy / change management""" from __future__ import absolute_import from __future__ import division diff --git a/superset/migrations/env.py b/superset/migrations/env.py index 07340485f8d4c..b9325dc168678 100755 --- a/superset/migrations/env.py +++ b/superset/migrations/env.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import with_statement import logging diff --git a/superset/models/annotations.py b/superset/models/annotations.py index 057aae2be6871..82619fdd49543 100644 --- a/superset/models/annotations.py +++ b/superset/models/annotations.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """a collection of Annotation-related models""" from __future__ import absolute_import from __future__ import division diff --git a/superset/models/core.py b/superset/models/core.py index 576f561a2adf6..2ad20faca85c6 100644 --- a/superset/models/core.py +++ b/superset/models/core.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """A collection of ORM sqlalchemy models for Superset""" from __future__ import absolute_import from __future__ import division diff --git a/superset/models/helpers.py b/superset/models/helpers.py index 718550bcad811..1431023be94d0 100644 --- a/superset/models/helpers.py +++ b/superset/models/helpers.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """a collection of model-related helper classes and functions""" from __future__ import absolute_import from __future__ import division diff --git a/superset/models/sql_lab.py b/superset/models/sql_lab.py index 5dfd8a6631f43..7e0ccb515cf11 100644 --- a/superset/models/sql_lab.py +++ b/superset/models/sql_lab.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """A collection of ORM sqlalchemy models for SQL Lab""" from __future__ import absolute_import from __future__ import division diff --git a/superset/security.py b/superset/security.py index e342b034d99cc..dbc3477bd5c3b 100644 --- a/superset/security.py +++ b/superset/security.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """A set of constants and methods to manage permissions and security""" from __future__ import absolute_import from __future__ import division diff --git a/superset/sql_lab.py b/superset/sql_lab.py index b470cbf08dde9..b52e9a95f6b38 100644 --- a/superset/sql_lab.py +++ b/superset/sql_lab.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/sql_parse.py b/superset/sql_parse.py index 83eac2715f910..790371ae35706 100644 --- a/superset/sql_parse.py +++ b/superset/sql_parse.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/stats_logger.py b/superset/stats_logger.py index 3caa38ada5c91..aaab8a11f19d6 100644 --- a/superset/stats_logger.py +++ b/superset/stats_logger.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/translations/utils.py b/superset/translations/utils.py index fb4f8404ee778..e221c49041290 100644 --- a/superset/translations/utils.py +++ b/superset/translations/utils.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/utils.py b/superset/utils.py index 2d06c48f2200a..25c4b581d9322 100644 --- a/superset/utils.py +++ b/superset/utils.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """Utility functions used across Superset""" from __future__ import absolute_import from __future__ import division diff --git a/superset/views/annotations.py b/superset/views/annotations.py index dea84561df4d1..e2aaf888da710 100644 --- a/superset/views/annotations.py +++ b/superset/views/annotations.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/views/base.py b/superset/views/base.py index 328789f0dbb66..dc2e48f43ae33 100644 --- a/superset/views/base.py +++ b/superset/views/base.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/views/core.py b/superset/views/core.py index b60d91c485ca7..2e01e99b3ab17 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/views/sql_lab.py b/superset/views/sql_lab.py index aac1d6d2c1d7d..faa2f16e45640 100644 --- a/superset/views/sql_lab.py +++ b/superset/views/sql_lab.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/views/utils.py b/superset/views/utils.py index b1f3fa2db7ffe..b02abea276bb5 100644 --- a/superset/views/utils.py +++ b/superset/views/utils.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W from __future__ import absolute_import from __future__ import division from __future__ import print_function diff --git a/superset/viz.py b/superset/viz.py index 5e6042dc46730..64064b38359ef 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -1,4 +1,5 @@ # -*- coding: utf-8 -*- +# pylint: disable=C,R,W """This module contains the 'Viz' objects These objects represent the backend of all the visualizations that diff --git a/tox.ini b/tox.ini index d942be1fb1239..2b2678eae4465 100644 --- a/tox.ini +++ b/tox.ini @@ -67,7 +67,7 @@ deps = [testenv:pylint] commands = - pylint superset --errors-only + pylint superset deps = -rrequirements.txt -rrequirements-dev.txt